651 Reply by joe

(14 replies, posted in Accounts Receivable)

Hello again,

I have now tested your example, @notrinos, and it doesn't work as intended.
I have now changed the function count_array($array) in /includes/ui/ui_globals.inc to this:

function count_array($array)
{
    return (is_array($array)) ? count($array) : (($array === NULL) ? 0 : 1);
}

and it works for PHP versions 7.2.12, 7.1.9, 7.0.23, 5.6.31, 5.5.25 and 5.4.10.

It gives the same return as the old count() without errors or warnings.
We only have to convert more counts() if we detect more errors. We can wait until next major to do this.

This has now been committed and a new file can be downloaded here:

/Joe.

Go to forum: Accounts Receivable

652 Reply by joe

(14 replies, posted in Accounts Receivable)

ok, I will just test this before committing.

Joe

Go to forum: Accounts Receivable

653 Reply by joe

(14 replies, posted in Accounts Receivable)

@notrinos

The function is_positive_int doesn't work as you provide in php 7.2.

However changing 

if (!is_positive_int($trans_no))
to
if (!trans_no)
do work.

what do you think?

joe

Go to forum: Accounts Receivable

654 Reply by joe

(11 replies, posted in Banking and General Ledger)

Hello Guys,
It seems that the column Journal # is used for Audit Trail (wrong header?). I will have to consult Janusz, to give a confirmation. It never seems to be used, although the Audit Trail table is updated on all transactions.
Just stay put.

/Joe

Go to forum: Banking and General Ledger

655 Reply by joe

(14 replies, posted in Accounts Receivable)

I guess you are right guys. Sorry that we didn't detect this before the minor release. However now it seems to work.
Please help me test it. You can make a global search on count_array and try to run the routines involved. It should be 6 files.

Committed to stable repo. New file can be downloaded here.

Joe

Go to forum: Accounts Receivable

656 Reply by joe

(14 replies, posted in Accounts Receivable)

Please try to give more details about this. I don't know how to fix it.

Joe

Go to forum: Accounts Receivable

657 Topic by joe

(4 replies, posted in Announcements)

Announcement

This is a 2.4.5 release, which is mainly bugfix release, but also contains a couple of improvements (see below for details).

Please report any bugs/problems found via our Mantis Bugtracker at http://mantis.frontaccounting.com.

Download instructions

In Sourceforge FrontAccounting (https:/sourceforge.net/projects/frontaccounting), select
Files -> FrontAccounting 2.4 ->2.4.5.

For Windows users select the zip file. For all other users select the tar.gz file.

Common

  • Fixed Session error in PHP 7.2.

  • Auto Increase of Document References (Company Setup)

  • Fixed a php 7.2 bug in db_pager.inc

  • Updated google url for currency converter.

  • Installer: added info about needed user database permissions.

  • Marker in Void Transactions fixed.

  • Utf-8 decoding not working for some special characters on pdf reports. @Braathwaate.

  • Fixed deprecated each() function in PHP 7.2. @notrinos.

  • Fixed php 7.2 count() compatibility and intval cast in number_format2 parameter 2.

  • Added input data check for company preferences. @notrinos.

  • Added missing input data check for Gl Setup. @notrinos.

  • Added Comany Setup Option. 'Open Print Dialog Direct on Reports'. @notrinos.

Sales

  • Fixed the summation of the outstanding open balance in Customer Balance Report.

  • The function get_customer_trans_details now includes itemPrice excl. tax in SQL.

  • Our Order No is always 0 on customer payment receipt. Fixed by empty column.

  • Ajax confirmation dialog ignored user answer in Sales Order cancelation - fixed.

  • 2.4.4 no Longer Displays 0.00 Sales Invoices in customer_inquiry.php. Fixed. @Braathwaate.

  • Fixed error creating customer credit note: Undefined index: sales_gl_code. @notrinos.

  • Left to allocate amount on sales documents was wrongly calculated. Fixed by @notrinos.

  • Fixed Customer Statement reflecting wrong balance. @Braath Waate.

  • New last_sales_order_detail function sql was very slow. Optimized by @Braathwaate.

  • Customer Balance showing wrong Outstanding balance (Journal Entry allocation) fixed, @kvvaradha.

Purchasing

  • Removed obsolete column 'Received' from direct purchase document entry forms.

  • Fixed SQL Problem in 'Aged Supplier Analysis'.

  • Fixed bug in Report Supplier Balances.

  • Purchase Order Delivery does not show the Supplier name in GL transactions report. @kvvaradha.

  • Suppliers: inactive tax groups should not appear in tax group selector for new supplier.

Items and Inventory

  • Stock goes negative even if the negative inventory is turned off. Fix by kvvaradha.

  • Solution for item editable description

  • Optimized Inventory Movement Report

  • Costed inventory Movements report did not reconcile. @Braatwaate.

  • Update material cost when quantity on hand is zero. @notrinos.

  • Item transactions should not show QOH for service items. @Braathwaate. Fixed by disabling transactions when non inventory item.

  • Items: item cloning did not preserved value for non-editable fields.

Manufacturing

  • New option in Workorder Listing report for optional listing of cost GL postings.

  • Work Order Entry: fixed error when voided WO reference is reused.

  • Print Work Orders: database error fixed when voided WO is in selected range.

  • Search Outstanding Work Orders: voided work orders excluded.

  • Fixed bug in costing procedure for produced items.

Dimensions

  • New feature: adding Attachments to Dimension

Bank and General Ledger

  • Update Journal Entry SQL query fixed.

  • GL inquiry person/item displays number instead of person, Fixed.

  • Cannot modify a funds transfer twice. Fixed by Braathwaate.

  • Fiscal year delete lead to undefined variable $total. Fixed.

  • Memo line was not cleared when entering new payment item. @Braathwaate.

  • Modifying Journal Transaction: fixed form layout for gl edition containing subaccount.

  • Fixed Revaluation amount was posted wrongly. @mugao-em and @andijani.

Go to forum: Announcements

658 Reply by joe

(82 replies, posted in FA Modifications)

Yes, I like jquery too, but haven't considered it useful for FA. I guess I will discuss it with Janusz.

Joe

Go to forum: FA Modifications

659 Reply by joe

(82 replies, posted in FA Modifications)

Yes, sure @notrinos. We could do it better. Feel free to experiment. What I would like is that we could change the diagrams,  the constants inside the diagrams etc. But remember that we should not convert to Google api. They can not be used for Arabic countries.

So go ahead and be creative ????

Joe

Go to forum: FA Modifications

660 Reply by joe

(26 replies, posted in Reporting)

These files have been committed to stable repo. Just replace the count() with count_array() in both places.

Thanks @notrinos for finding these.

Please continue testing. Thanks in advance.

/Joe

Go to forum: Reporting

661 Reply by joe

(26 replies, posted in Reporting)

I have now committed a fix, where the count() was replaced with count_array(). It was only needed in 3 files and the count_array() was added at the end in the file /includes/ui/ui_globals.inc.

The files are:
/admin/db/maintenance_db.inc(186): $cnt = max(1, count_array($db_connections));
/reporting/includes/reports_classes.inc(37): $class_id = count_array($this->ar_classes);
/sales/includes/sales_db.inc(371): if (!count_array($trans_no))

and the count_array definition:
/includes/ui/ui_globals.inc(65): function count_array($array)

I have been testing FA all over, but I will ask you who has the PHP 7.2.X installed to download a snapshot of 2.4.4 from the repo here.

There was also a problem with the 2.nd parameter in number_format2 in the file /includes/current_user.inc. We used a float value as an integer parameter. Fixed with intval().

Please help me test this snapshot so we can find more odd count() and other problems.

Thank you in advance.

Joe

Go to forum: Reporting

662 Reply by joe

(26 replies, posted in Reporting)

I see that the functions rename_function and override_function are not part of the standard PHP and therefore can not be used.

I will follow @cleal example and review all the count() calls. Where the check is needed I will use the count_array() instead of  count().

Joe

Go to forum: Reporting

663 Reply by joe

(26 replies, posted in Reporting)

I will test a solution with rename_function and override_function.
We will include a new file with specific functions with new behaviors if
  version_compare >= 7.2.0

Then we do not need to change anything in the code.

Joe

Go to forum: Reporting

664 Reply by joe

(3 replies, posted in Report Bugs here)

This issue has been fixed and committed to stable release. The fixed file can be downloaded here.

@apmuthu.

I guess your solution with alter tables can wait until the next major. For those needed this, they can run this solution on their databases.

/Joe

Go to forum: Report Bugs here

665 Reply by joe

(3 replies, posted in Report Bugs here)

I see. Will commit in a while. Thanks.

Joe

Go to forum: Report Bugs here

666 Reply by joe

(4 replies, posted in Reporting)

This has been fixed, both on screen and in report. Committed to stable repo. Thanks @kvvaradha.

/Joe

Go to forum: Reporting

667 Reply by joe

(4 replies, posted in Reporting)

Willdo later.

Joe

Go to forum: Reporting

668 Reply by joe

(7 replies, posted in Accounts Receivable)

The problem was fixed on the supplier side in another way.

This issue has been fixed and committed to stable. You can download the fixed file here. Thanks @kvvaradha.

/Joe

Go to forum: Accounts Receivable

669 Reply by joe

(7 replies, posted in Accounts Receivable)

You are right, your solution fixes the problem.

I will just check if we have the same problem on the supplier side.

/Joe

Go to forum: Accounts Receivable

670 Reply by joe

(7 replies, posted in Accounts Receivable)

Ok, I didn't try the allocation of the Journal Entry. Just a minute.

/Joe

Go to forum: Accounts Receivable

671 Reply by joe

(9 replies, posted in Banking and General Ledger)

Hello,

I guess you are right, guys. I just wonder how this bug could have been here for so long.
The bug has been fixed and committed to stable repo.
The fixed file can be downloaded here.

Please make a test that this is working ok now. Also check that the AR/AP accounts are updated correctly.

/Joe

Go to forum: Banking and General Ledger

672 Reply by joe

(7 replies, posted in Accounts Receivable)

@kvvaradha

Are you sure you are operating on the latest stable repo? We have fixed a lot of bugs here, includeing the Journal Entries.
If you have entered the Journal Entry before the bugs were fixed, then you get the wrong balances.

With the latest repo, I cannot reproduce your issue. Everything is ok here.

/Joe

Go to forum: Accounts Receivable

673 Reply by joe

(9 replies, posted in Setup)

This has been added to stable repo. A Company Setup has been added. 'Open Print Dialog Direct On Reports'. Default not marked.

Joe

Go to forum: Setup

674 Reply by joe

(6 replies, posted in Report Bugs here)

I will have a look.

Joe

Go to forum: Report Bugs here

675 Reply by joe

(6 replies, posted in Report Bugs here)

We are planning a minor 2.4.5 release soon.

We just have to examine the Mantis Bug Tracker.

Joe

Go to forum: Report Bugs here