651 Reply by joe

(26 replies, posted in Reporting)

I have now committed a fix, where the count() was replaced with count_array(). It was only needed in 3 files and the count_array() was added at the end in the file /includes/ui/ui_globals.inc.

The files are:
/admin/db/maintenance_db.inc(186): $cnt = max(1, count_array($db_connections));
/reporting/includes/reports_classes.inc(37): $class_id = count_array($this->ar_classes);
/sales/includes/sales_db.inc(371): if (!count_array($trans_no))

and the count_array definition:
/includes/ui/ui_globals.inc(65): function count_array($array)

I have been testing FA all over, but I will ask you who has the PHP 7.2.X installed to download a snapshot of 2.4.4 from the repo here.

There was also a problem with the 2.nd parameter in number_format2 in the file /includes/current_user.inc. We used a float value as an integer parameter. Fixed with intval().

Please help me test this snapshot so we can find more odd count() and other problems.

Thank you in advance.

Joe

Go to forum: Reporting

652 Reply by joe

(26 replies, posted in Reporting)

I see that the functions rename_function and override_function are not part of the standard PHP and therefore can not be used.

I will follow @cleal example and review all the count() calls. Where the check is needed I will use the count_array() instead of  count().

Joe

Go to forum: Reporting

653 Reply by joe

(26 replies, posted in Reporting)

I will test a solution with rename_function and override_function.
We will include a new file with specific functions with new behaviors if
  version_compare >= 7.2.0

Then we do not need to change anything in the code.

Joe

Go to forum: Reporting

654 Reply by joe

(3 replies, posted in Report Bugs here)

This issue has been fixed and committed to stable release. The fixed file can be downloaded here.

@apmuthu.

I guess your solution with alter tables can wait until the next major. For those needed this, they can run this solution on their databases.

/Joe

Go to forum: Report Bugs here

655 Reply by joe

(3 replies, posted in Report Bugs here)

I see. Will commit in a while. Thanks.

Joe

Go to forum: Report Bugs here

656 Reply by joe

(4 replies, posted in Reporting)

This has been fixed, both on screen and in report. Committed to stable repo. Thanks @kvvaradha.

/Joe

Go to forum: Reporting

657 Reply by joe

(4 replies, posted in Reporting)

Willdo later.

Joe

Go to forum: Reporting

658 Reply by joe

(7 replies, posted in Accounts Receivable)

The problem was fixed on the supplier side in another way.

This issue has been fixed and committed to stable. You can download the fixed file here. Thanks @kvvaradha.

/Joe

Go to forum: Accounts Receivable

659 Reply by joe

(7 replies, posted in Accounts Receivable)

You are right, your solution fixes the problem.

I will just check if we have the same problem on the supplier side.

/Joe

Go to forum: Accounts Receivable

660 Reply by joe

(7 replies, posted in Accounts Receivable)

Ok, I didn't try the allocation of the Journal Entry. Just a minute.

/Joe

Go to forum: Accounts Receivable

661 Reply by joe

(9 replies, posted in Banking and General Ledger)

Hello,

I guess you are right, guys. I just wonder how this bug could have been here for so long.
The bug has been fixed and committed to stable repo.
The fixed file can be downloaded here.

Please make a test that this is working ok now. Also check that the AR/AP accounts are updated correctly.

/Joe

Go to forum: Banking and General Ledger

662 Reply by joe

(7 replies, posted in Accounts Receivable)

@kvvaradha

Are you sure you are operating on the latest stable repo? We have fixed a lot of bugs here, includeing the Journal Entries.
If you have entered the Journal Entry before the bugs were fixed, then you get the wrong balances.

With the latest repo, I cannot reproduce your issue. Everything is ok here.

/Joe

Go to forum: Accounts Receivable

663 Reply by joe

(9 replies, posted in Setup)

This has been added to stable repo. A Company Setup has been added. 'Open Print Dialog Direct On Reports'. Default not marked.

Joe

Go to forum: Setup

664 Reply by joe

(6 replies, posted in Report Bugs here)

I will have a look.

Joe

Go to forum: Report Bugs here

665 Reply by joe

(6 replies, posted in Report Bugs here)

We are planning a minor 2.4.5 release soon.

We just have to examine the Mantis Bug Tracker.

Joe

Go to forum: Report Bugs here

666 Reply by joe

(6 replies, posted in Report Bugs here)

This has now been fixed and committed to stable repo. Thanks @notrinos.

The fixed file can be downloaded here.

Joe

Go to forum: Report Bugs here

667 Reply by joe

(6 replies, posted in Report Bugs here)

Ok, willdo.

Joe

Go to forum: Report Bugs here

668 Topic by joe

(0 replies, posted in Development)

Hello,

Due to the many developers contributing to FA source, we will change the Copyright note in the beginning of most source files to:
Copyright (c) FrontAccounting Team (see README.md).

And in the README.md we will mention the members that have contributed to the FA source.

We plan to do this in the next major (2.5) release.

/Joe

Go to forum: Development

669 Topic by joe

(0 replies, posted in Development)

Hello Guys,

Our default theme is a bit outdated at the moment. If anyone of you developers/senior members have a proposal for a new default theme, please contribute. It will be much appreciated.

I would like to see some fancy, simple, examples.

Thanks in advance.

/Joe

Go to forum: Development

670 Reply by joe

(1 replies, posted in Report Bugs here)

This has been committed to stable repo.

A fixed version can be downloaded here.

Thanks @notrinos.

Joe

Go to forum: Report Bugs here

671 Reply by joe

(9 replies, posted in Banking and General Ledger)

Hello again.

@mugao-em.
The Gain/Loss account is an operation account. A gain is entered as a credit amount and a loss is entered as a debit amount.
In the Cutomer Receivables/Supplier Payables Account it should be entered as a debit amount for Gain. Credit amount for Loss.

Please show the Journal Entries.

/Joe

Go to forum: Banking and General Ledger

672 Reply by joe

(9 replies, posted in Banking and General Ledger)

This was written a long time ago and should have had a long test period.

Joe

Go to forum: Banking and General Ledger

673 Reply by joe

(7 replies, posted in FA Modifications)

I will have a look into this.

Joe

Go to forum: FA Modifications

674 Reply by joe

(26 replies, posted in Reporting)

Yes maybe a good idea.

Joe

Go to forum: Reporting

675 Reply by joe

(26 replies, posted in Reporting)

The bug in report_classes.inc has been fixed and committed.
A fixed copy can be downloaded here.

Joe

Go to forum: Reporting