626 Reply by joe

(11 replies, posted in Reporting)

A couple of minor issues are fixed in the rep115.php and rep206. The no_zeroes parameter didn't work and some parameters were missing in the rep115.php report. The files are committed to repo and you can re-download them a bit up.

We are not glad for the Copyright notice in the beginning of the 2 files. We are going to change our copyright to be FrontAccounting Team from next major 2.5. In the readme.md files we are going to present the active developers in the FrontAccounting Team.
For now I have changed the Copyright to FrontAccounting Team for the 2 files.
A bit down there are a field called 'Creator'. We will use that field for the Team Member that have created the file.
I hope you are ok with this, @boxygen.

/Joe

Go to forum: Reporting

627 Reply by joe

(11 replies, posted in Reporting)

The 2 reports has been added to core and are committed.

You can download the 3 files
/reporting/rep115.php
/reporting/rep206.php
/reporting/reports_main.php

/Joe

Go to forum: Reporting

628 Reply by joe

(11 replies, posted in Reporting)

wow, you are my man, @boxygen.

Will incorporate this as well. will be committed later this afternoon.

/Joe

Go to forum: Reporting

629 Reply by joe

(82 replies, posted in FA Modifications)

@boxygen,

Yes, i agree. I am just waiting for @notrinos suggestions about what to change in the core to help modularizing the Dashboard.

@boxygen, @notrinos and @apmuthu.

Thank you for your creative coop in this and other matters.

/Joe

Go to forum: FA Modifications

630 Reply by joe

(11 replies, posted in Reporting)

Hi @boxygen,

This is a nice and productive report. Let me incorporate this in the core.
Maybe a good idea to also make a Supplier Trial Balance, right?

/Joe

Go to forum: Reporting

631 Reply by joe

(20 replies, posted in Report Bugs here)

The 3 Providers, ECB, CCA and EXCHANGE-RATES.ORG is working now and the /gl/includes/db/gl_db_rates.inc is committed as well as config.default.php.
They can be downloaded here and here.

Please copy the $xr_providers array from config.default.php to your config.php.

/Joe

Go to forum: Report Bugs here

632 Reply by joe

(20 replies, posted in Report Bugs here)

Hello @notrinos

I got the following errors when using

Yahoo
Undefined offset: 1 in file: C:\wamp3\www\account24\gl\includes\db\gl_db_rates.inc at line 228
Google
Cannot retrieve exchange rate for currency GBP. Please adjust approximate rate if needed.
Bloomberg
Cannot retrieve exchange rate for currency GBP. Please adjust approximate rate if needed.

I think we could just commit it. The 3 first providers works OK. We can then investigate further on the others, right?

/Joe

Go to forum: Report Bugs here

633 Reply by joe

(20 replies, posted in Report Bugs here)

Sure @notrinos. Thanks for the investigation.

I will just test them all and commit them later.

/Joe

Go to forum: Report Bugs here

634 Reply by joe

(20 replies, posted in Report Bugs here)

Hello @boxygen,

Your code for CCA doesn't work. It gives no rates. Will you give it a check, please? Thanks.

/Joe

Go to forum: Report Bugs here

635 Reply by joe

(20 replies, posted in Report Bugs here)

Hello @apmuthu,

Yes I will include your fix and @boxygen's provider in FA later this evening.

Joe

Go to forum: Report Bugs here

636 Reply by joe

(11 replies, posted in Banking and General Ledger)

Hello Guys,

I have now been in contact with Janusz and he has explained the implementation.

The Journal # in GL trans view is a column for transactions that are closed by 'Closing GL Transactions' in Banking & General Ledger.
We have changed the column header to GL #. It will show 'None' for inside a non closing period and a serial number for inside a closing period.

Some small adjustments have been done. Committed to Repo.

File /includes/ui/ui_view.inc can be downloaded here
File /gl/view/gl_trans_view.php can be downloaded here
File /gl/inquiry/journal_inquiry.php can be downloaded here.

Joe

Go to forum: Banking and General Ledger

637 Reply by joe

(20 replies, posted in Report Bugs here)

This seems to be reliable and has been included in FA. Committed to stable repo. Thanks @notrinos.

new file: config-default.php can be downloaded here. (trailing tab in affected line to be fixed later)
new file: /gl/includes/db/gl_db_rates.inc can be downloaded here.

Joe

Go to forum: Report Bugs here

638 Reply by joe

(20 replies, posted in Report Bugs here)

I will have a look into this. Sounds great @notrinos. It looks that the new provider is sponsored by bank N26, Germany.

Joe

Go to forum: Report Bugs here

639 Topic by joe

(0 replies, posted in Report Bugs here)

Credit Notes were never seen in View Sales Order.

Fixed and committed to repo. You can download the fixed file here.

/Joe

Go to forum: Report Bugs here

640 Reply by joe

(7 replies, posted in Report Bugs here)

Sorry Guys, of course you are right.

This has been committed to repo. The new /reporting/rep202.php can be downloaded here.

/Joe

Go to forum: Report Bugs here

641 Topic by joe

(0 replies, posted in Accounts Receivable)

Pressing the Batch Button in the table when there were no records caused a missing index error.

This has been fixed and committed.

Joe

Go to forum: Accounts Receivable

642 Reply by joe

(7 replies, posted in Report Bugs here)

@apmuthu,
But is the bug reported for line 214 when go_debug is set to 2? In php 7.2?

Not in my environment. We will only fix shown warnings/bugs, right?

This has been committed to repo. File /reporting/rep102.php can be downloaded here.

Joe

Go to forum: Report Bugs here

643 Reply by joe

(7 replies, posted in Report Bugs here)

Thanks @notrinos,

Will commit this in a while.

Joe

Go to forum: Report Bugs here

644 Reply by joe

(8 replies, posted in Items and Inventory)

Hello,

Please address this to Janusz directly. I see he is responsible for the change. Quite complicated.

/Joe

Go to forum: Items and Inventory

645 Reply by joe

(14 replies, posted in Accounts Receivable)

Hello again,

I have now tested your example, @notrinos, and it doesn't work as intended.
I have now changed the function count_array($array) in /includes/ui/ui_globals.inc to this:

function count_array($array)
{
    return (is_array($array)) ? count($array) : (($array === NULL) ? 0 : 1);
}

and it works for PHP versions 7.2.12, 7.1.9, 7.0.23, 5.6.31, 5.5.25 and 5.4.10.

It gives the same return as the old count() without errors or warnings.
We only have to convert more counts() if we detect more errors. We can wait until next major to do this.

This has now been committed and a new file can be downloaded here:

/Joe.

Go to forum: Accounts Receivable

646 Reply by joe

(14 replies, posted in Accounts Receivable)

ok, I will just test this before committing.

Joe

Go to forum: Accounts Receivable

647 Reply by joe

(14 replies, posted in Accounts Receivable)

@notrinos

The function is_positive_int doesn't work as you provide in php 7.2.

However changing 

if (!is_positive_int($trans_no))
to
if (!trans_no)
do work.

what do you think?

joe

Go to forum: Accounts Receivable

648 Reply by joe

(11 replies, posted in Banking and General Ledger)

Hello Guys,
It seems that the column Journal # is used for Audit Trail (wrong header?). I will have to consult Janusz, to give a confirmation. It never seems to be used, although the Audit Trail table is updated on all transactions.
Just stay put.

/Joe

Go to forum: Banking and General Ledger

649 Reply by joe

(14 replies, posted in Accounts Receivable)

I guess you are right guys. Sorry that we didn't detect this before the minor release. However now it seems to work.
Please help me test it. You can make a global search on count_array and try to run the routines involved. It should be 6 files.

Committed to stable repo. New file can be downloaded here.

Joe

Go to forum: Accounts Receivable

650 Reply by joe

(14 replies, posted in Accounts Receivable)

Please try to give more details about this. I don't know how to fix it.

Joe

Go to forum: Accounts Receivable