601 Reply by joe

(14 replies, posted in Manufactoring)

Fixed and rolled back to repo.

New file can be downloaded here.

/Joe

Go to forum: Manufactoring

602 Reply by joe

(14 replies, posted in Manufactoring)

Ok I will roll it back in a while.

Joe

Go to forum: Manufactoring

603 Reply by joe

(14 replies, posted in Modules Add-on's)

Yes, they should. These have only a few parameters. The rest is default.

/Joe

Go to forum: Modules Add-on's

604 Reply by joe

(47 replies, posted in Modules Add-on's)

I think we will make a poll when @notrinos has presented his new theme.

Simply let the audience decide which should be candidates. We usually have 3 themes in the core, but the other can be set as extensions. I guess there are several old themes that can be taken away from the extensions.

The best one will be the default theme. Democratic, right?

/Joe

Go to forum: Modules Add-on's

605 Reply by joe

(47 replies, posted in Modules Add-on's)

@kvvaradha.

Yes it looKs better. Still I think the icons is too dominating. Mayby it is the Material design. Of course it is a matter of taste smile.

Joe

Go to forum: Modules Add-on's

606 Reply by joe

(14 replies, posted in Modules Add-on's)

This is fixed and committed to repo.

/Joe

Go to forum: Modules Add-on's

607 Reply by joe

(14 replies, posted in Modules Add-on's)

Ok, I understand. I think I will just use your get_gl_transactions for now. To fix the timeout problem.

And put the extra null parameter in gl_account_inquiry.php.

We could then easily get more fix here later. Thanks for helping.

Joe

Go to forum: Modules Add-on's

608 Reply by joe

(14 replies, posted in Modules Add-on's)

@braathwaate

Or do you want 2 extra input filters on the gl inquiry, person-type and person combo. In that case we should probably use som ajax-update when selecting.

/Joe

Go to forum: Modules Add-on's

609 Reply by joe

(14 replies, posted in Modules Add-on's)

@braathwaate

Any change to parameters in the file gl_account_inquiry.php that calls get_gl_transactions?

This is the only file that are different in the new parameter list.

/Joe

Go to forum: Modules Add-on's

610 Reply by joe

(14 replies, posted in Modules Add-on's)

@apmuthu or @Braathwaate,

Where can I find the specific variant of get_transactions?

/joe

Go to forum: Modules Add-on's

611 Reply by joe

(47 replies, posted in Modules Add-on's)

Hello @kvvaradha.

I have choosen another approach. In login.php all the initial stuff are processed here. Then the theme login.inc file is called if such a file exists, mostly for the design part, and the final stuff is again processed in login.php. This approach will eleminate the risk of forgetting stuff in the theme login.
If no login.inc file exists a default login is used.

The problem is the catch 22 part. We don't know the user theme before the login is effective. But we will find a solution to this. Ii am working on that.

Then reset of the password file is almost a copy of the login.php file. It could be processed the same way. I will see if we can merge the reset password file and the login.php file.

Joe

Go to forum: Modules Add-on's

612 Reply by joe

(14 replies, posted in Modules Add-on's)

@apmuthu
Your optimized function has been committed to core.

Regarding @braathwaate's get_transactions function, I will have to check it carefully before syncing.

/Joe

Go to forum: Modules Add-on's

613 Reply by joe

(47 replies, posted in Modules Add-on's)

@apmuthu,

Yes this was caused by the lock of the menus. This has now been fixed and uploaded. All the 3 themes have locked menus, so you can scroll and the menus stay there. But thanks for testing.

I have now replaced the login with another one belonging to default2. It will work with all 3 themes, because there are only include files in that theme folder.

I had to reorganize a bit, but had to be careful, due to several things taking place here.

It is not easy to let the theme taking over the login box, because we have a so called catch 22 situation. We first know the user after login. And the themes are user based. But we will solve that in some way.

So for now it is hard coded in the local login.php (with a local login.inc in the theme folder).

We will find out a solution for this. A nearby solution is to set the default theme in the config.php file, but this is not the best solution. Well let us think a little.

You have the username and password above in a reply.

or User: testing, Pass: password

/Joe

Go to forum: Modules Add-on's

614 Reply by joe

(14 replies, posted in Report Bugs here)

I will have Janusz to look at this.

Joe

Go to forum: Report Bugs here

615 Reply by joe

(47 replies, posted in Modules Add-on's)

I am just thinking loudly smile. Maybe we can let the existing /access/login.php and /access/logout.php check if there is a login/logout file in the theme folder, and if so, redirect the login and logout. Just a thought.

Or maybe we can organize just the design part and only let this redirect. Just for security.

/Joe

Go to forum: Modules Add-on's

616 Reply by joe

(6 replies, posted in FA Modifications)

Hello Guys,

This has been committed to stable repo. Thanks @kvvaradha and @apmuthu.

The fixed file can be downloaded here.

Joe

Go to forum: FA Modifications

617 Reply by joe

(47 replies, posted in Modules Add-on's)

@apmuthu.

Please make another test. I have uploaded another ex. Ok here in Safari, Chrome, Firefox, IE and Microsoft Edge.

If not, please state your equipment. Thanks in advance.

Joe

Go to forum: Modules Add-on's

618 Reply by joe

(47 replies, posted in Modules Add-on's)

Hello again Guys,

I have uploaded 3 new themes that are based on flat simple colors and flat icons from flaticons.net. They have many good icons and it is easy to color the icons before downloading.

The Default2 theme, is mirroring the Default theme, but it has gone a major update.

The Flatcolor Theme is a new theme, also with flat colors. A horizontal menu at the top and a module menu dropdown.

The third, Flatcolor2 is with a sidebar accordion menu, that can be expanded and taken away with the Menu sign above the sidebar. This could be a candidate outside the defaults.

They all need a little fine tuning but please give your comments.

Did you improve yours a bit, @kvvaradha. I also guess that @notrinos has one coming. Exiting!

The url is:

https://frontaccounting.com/fa24test

User: testing
Pass: password

The testing user is only allowed to make queries.

/Joe

Go to forum: Modules Add-on's

619 Reply by joe

(7 replies, posted in Report Bugs here)

This has been fixed and committed to stable repo. Thanks @notrinos.

The fixed file can be downloaded here.

/Joe

Go to forum: Report Bugs here

620 Reply by joe

(47 replies, posted in Modules Add-on's)

@kvvaradha.

A good theme, however I think the icons are a little too black and dominating. I would prefer a color of #333 or #444.
The grey section at the top is too height. It is difficult to have all the menu info on screen without scrolling.
But this can be fixed.
At the same time I have also been working on a couple of themes, one of them could also be in the standard themes. I will publish them in a couple of days.
But thank you for doing this.

/Joe

Go to forum: Modules Add-on's

621 Reply by joe

(5 replies, posted in Modules Add-on's)

Hello @kvvaradha

This has been fixed And I have sent it to Janusz and asked him to upload it to the extension repo.

Thank you for finding this issue. And a Happy New Year to you and the rest of the members.

/Joe

Go to forum: Modules Add-on's

622 Reply by joe

(5 replies, posted in Modules Add-on's)

Ok, this is an extension report, but I will have a look at it.

Joe

Go to forum: Modules Add-on's

623 Topic by joe

(2 replies, posted in Announcements)

Announcement

This is a 2.4.6 release, which is mainly bugfix release, but also contains a couple of improvements (see below for details).
In this release some sql injection vulnerabilities were fixed. Please feel encouraged to update as soon as possible,
especially if your FrontAccounting site is publicly available or runs in untrusted environment.

Please report any bugs/problems found via our Mantis Bugtracker at http://mantis.frontaccounting.com.

Download instructions

In Sourceforge FrontAccounting (https:/sourceforge.net/projects/frontaccounting), select
Files -> FrontAccounting 2.4 ->2.4.6.

For Windows users select the zip file. For all other users select the tar.gz file.

Common

  • Fixed Bug in count_array(), /includes/ui/ui_globals.inc.

  • Fixed a non well formed numeric value encountered rep102.php and rep202.php when running php 7.2.

  • New reliable currency rate provider, EXCHANGE-RATES.ORG added as default.

  • No exchange rate was working in FA now. Fixed ECB, CCA and EXCHANGE-RATES.ORG. More fixes to come.

  • Attach Documents: fixed SQL injection vulnerability.

Sales

  • Pressing the Batch button in Invoice against Deliveries got a missing indexes. Fixed.

  • Credit Notes were never seen in View Sales Order. Fixed.

  • Bug 4796: Entering customer payment with a bank charge equal to the total amount results in database error. Fixed.

  • Added new report, Customer Trial Balance.

Purchasing

  • Added new report, Supplier Trial Balance.

Items and Inventory

  • Report Stock Check Sheet is now testing for valid barcodes of EAN, EAN-8, EAN-13, GTIN-8, GTIN-12, GTIN-14, UPC,
    UPC-12 coupon code, JAN if 'Using Barcodes' is enabled. More test to come later

Bank and General Ledger

  • Changed Journal # to GL # in GL Trans View. This was a little confusing.

  • Bug 4811: magnifying glass select on deposits/payments erroneously shows bank account gl accounts. Fixed.

  • Bug 4821: banking overdraft message had php errors. Fixed.

Go to forum: Announcements

624 Reply by joe

(8 replies, posted in Items and Inventory)

We have now established a Barcode Checker for the following types: 

EAN, EAN-8, EAN-13, GTIN-8, GTIN-12, GTIN-14, UPC, UPC-12 coupon code, JAN

This will be committed in a while.
If we later find som further testing of barcode types we will add these as well.

/Joe

Go to forum: Items and Inventory

625 Reply by joe

(8 replies, posted in Items and Inventory)

We don't have a $type when calling is_valid_barcode.

I have been trying this:

function is_valid_barcode($code)
{
    $types = array("EAN2", "EAN5", "EAN8", "EAN13", "UPCA", "UPCE", "C39", "C39+", "C39E", "C39E+", "I25", 
        "C128A", "C128B", "C128C", "POSTNET", "CODABAR");

    foreach ($types as $type)
    {
        if (substr($type, 0, 3) === "EAN" || substr($type, 0, 3) == "UPC")
        {
            if (!preg_match("/^[0-9]+$/", $code))
                continue;
        }        
           $barcode = new TCPDFBarcode($code, $type);
        $chk = $barcode->getBarcodeArray();
        if ($chk !== false)
            return true;
    }
    return false;
}

But if alphanumerical characters it is still testing. It shouldn't if EAN of UPC. Please try it.

Maybe I have overseen something, so please help.

/Joe

Go to forum: Items and Inventory