This has been fixed and committed to repo. A fixed file can be downloaded here.

/Joe

I don't know. Will have a look later.

Joe

You can also print the supplier Invoice View. The print option is to the left of the close link.

Joe

@apmuthu. I don't know yet.
You should address this question to @notrinos.
I don't have the complete picture yet.

Joe

This is fixed. My fault. Sorry. Thanks @notrinos. Committed to stable.

/Joe

There is no meaning in printing a Suppliers Invoice. You have got one from him, either hardcopy or softcopy. You can attach this document to the supplier Invoice record.

Best regards

Joe

582

(3 replies, posted in Report Bugs here)

Well, I see that this has never been updated for release 2.4. This must be a mistake, and I will fix this. But you can download the file included here. Unpack it and replace the files in /themes/elegant folder.
And you should be going.

Thank you for your nice words.

/Joe

583

(3 replies, posted in Report Bugs here)

Of course, I will have a look.

/Joe

Committed and new file here.

Joe

Fixed and rolled back to repo.

New file can be downloaded here.

/Joe

Ok I will roll it back in a while.

Joe

Yes, they should. These have only a few parameters. The rest is default.

/Joe

I think we will make a poll when @notrinos has presented his new theme.

Simply let the audience decide which should be candidates. We usually have 3 themes in the core, but the other can be set as extensions. I guess there are several old themes that can be taken away from the extensions.

The best one will be the default theme. Democratic, right?

/Joe

@kvvaradha.

Yes it looKs better. Still I think the icons is too dominating. Mayby it is the Material design. Of course it is a matter of taste smile.

Joe

This is fixed and committed to repo.

/Joe

Ok, I understand. I think I will just use your get_gl_transactions for now. To fix the timeout problem.

And put the extra null parameter in gl_account_inquiry.php.

We could then easily get more fix here later. Thanks for helping.

Joe

@braathwaate

Or do you want 2 extra input filters on the gl inquiry, person-type and person combo. In that case we should probably use som ajax-update when selecting.

/Joe

@braathwaate

Any change to parameters in the file gl_account_inquiry.php that calls get_gl_transactions?

This is the only file that are different in the new parameter list.

/Joe

@apmuthu or @Braathwaate,

Where can I find the specific variant of get_transactions?

/joe

Hello @kvvaradha.

I have choosen another approach. In login.php all the initial stuff are processed here. Then the theme login.inc file is called if such a file exists, mostly for the design part, and the final stuff is again processed in login.php. This approach will eleminate the risk of forgetting stuff in the theme login.
If no login.inc file exists a default login is used.

The problem is the catch 22 part. We don't know the user theme before the login is effective. But we will find a solution to this. Ii am working on that.

Then reset of the password file is almost a copy of the login.php file. It could be processed the same way. I will see if we can merge the reset password file and the login.php file.

Joe

@apmuthu
Your optimized function has been committed to core.

Regarding @braathwaate's get_transactions function, I will have to check it carefully before syncing.

/Joe

@apmuthu,

Yes this was caused by the lock of the menus. This has now been fixed and uploaded. All the 3 themes have locked menus, so you can scroll and the menus stay there. But thanks for testing.

I have now replaced the login with another one belonging to default2. It will work with all 3 themes, because there are only include files in that theme folder.

I had to reorganize a bit, but had to be careful, due to several things taking place here.

It is not easy to let the theme taking over the login box, because we have a so called catch 22 situation. We first know the user after login. And the themes are user based. But we will solve that in some way.

So for now it is hard coded in the local login.php (with a local login.inc in the theme folder).

We will find out a solution for this. A nearby solution is to set the default theme in the config.php file, but this is not the best solution. Well let us think a little.

You have the username and password above in a reply.

or User: testing, Pass: password

/Joe

I will have Janusz to look at this.

Joe

I am just thinking loudly smile. Maybe we can let the existing /access/login.php and /access/logout.php check if there is a login/logout file in the theme folder, and if so, redirect the login and logout. Just a thought.

Or maybe we can organize just the design part and only let this redirect. Just for security.

/Joe

Hello Guys,

This has been committed to stable repo. Thanks @kvvaradha and @apmuthu.

The fixed file can be downloaded here.

Joe