So at my place everything works ok both in php8 and minors.

Joe

I cannot reproduce this for release 2.4.13. Regarding sending to bcc, I can see a problem. Will investigate this.

Joe

1. On 2.4.12 it did not email the invoice when the server runs on PHP8, when reverting to 7.4 it sends correctly. On 2.4.13  with PHP8, the email is sent, but only in text. The invoice is then also in text and no copy to the bcc field. Also now pdf attachment.

"Subject: Invoice AWI0152 from Aquilla "
"--b640baceb3efdf08f767f71957c1a6cf
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit

Dear ,"

The client's name is not in the email,

The rest of the content sent to the client:

"--b640baceb3efdf08f767f71957c1a6cf
Content-Type: application/unknown; name="InvoiceAWI0152.pdf"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="InvoiceAWI0152.pdf"

JVBERi0xLjMKMS4wMCB3CjMgMCBvYmoKPDwvVHlwZSAvUGFnZQovUGFyZW50IDEgMCBSCi9N
ZWRpYUJveCBbMCAwIDU5NS4yOCA4NDEuODldCi9SZXNvdXJjZXMgMiAwIFIKL0NvbnRlbnRz" This goes on for a bit.

This is just one error that I have picked up.

When reverting back to 7.4 it sends it correctly, to the client but does not send a bcc email to the company.

CHANGELOG

Github Master (Bleeding Edge) Download Link

These fixes can be applied to (overwrite) the release version to be fully functional.

After consulting Janusz regarding the --sort-output, we have decided NOT to change the sorting now. If this could be matured a bit then maybe in some coming minors.

A final version of the empty.po will be committed to stable in a while.

Joe

#!/usr/bin/bash

cat empty.po | while read -r line
do  
  if [[ ${line:0:1} == "#" ]]
  then
    echo "${line}" | sed -e 's/\\/\//g' # 116.94 secs
#    echo "${line}" | tr '\\' '/' # 118.61 secs
  else
    echo -E "${line}"
  fi
done  > empty_ordered.po;

I have added in the "fuzzy" line and the "Report Bugs to" line as well and ordered all the strings and attached it herein, Compared with yours too and strings are all okay except for some #references out of order.

The timer script for efficiency checks is:

#!/bin/sh

# This should be at the top of the script to get the start time of the script
start=$(date +%s.%N)

# Here you can place your function
sh $1

# bc not there in Git Bash
# duration=$(echo "$(date +%s.%N) - $start" | bc)
fin=$(date +%s.%N)
duration=$(awk '{print $1-$2}' <<<"${fin} ${start}")
execution_time=`printf "%.2f seconds" $duration`

echo "Script $1 Execution Time: $execution_time"

# Usage: timer gettext_order.sh

Place the timer script in C:\Program Files\Git\mingw64\bin folder for windows users as there is no "bc" command in the minimal bash in Windows Git and an "awk" workaround is substituted and used for testing any script.

I will push this to repo tomorrow.

/Joe

cat empty_bs.po |  tr '\\' '\/' > empty_fs.po

Further "if" can be introduced to restrict it to lines that start with "#".

I have now found the solution for fixing the empty.po file in Windows.

Please have a look at the empty.zip. The empty.po is sorted and no install files are included longer. And the line-ending is unix.

Could it be better?

If ok, I will commit it to stable.

/Joe

Thanks.

Joe

Install Git for windows (47 MB) and TortoiseGit (20 MB).

Right Click on any folder (like frontac24 repo folder) and choose "Git Bash Here" and you can execute linux commands natively. Some missing linux binaries for windows like wget can be obtained from the likes of here. The wget.exe file needs to be placed at C:\Program Files\Git\mingw64\bin.

I used a linux bash file from Janusz, that I translated to Windows bat file. I see that it is not working correctly.

My environment is Windows 11 and I am working in WampApache64 and this environment is very handy trapping  php 8 errors.

Please provide an empty.po file for download here. Are you good at translating linux bash file into Windows bat file? If so, please provide a translation here.

/Joe

1 string is changed between the older core and the current one:
" overdue Purchase Invoices"
is now
" unpaid Purchase Invoices"

It is better to re-create the core empty.po file and make for a re-release.

There is really no new strings in the empty.po other than the changed string listed above.

Here is a quick 'n dirty script to extract all gettext strings in FA:

find /var/www/frontac/ \( -name "*.php" -o -name "*.inc" \) ! -path "./tmp/*" | \
sort -bdf | \
xargs xgettext \
--default-domain=myapp \
--output=myapp.pot \
--language=PHP \
--indent \
--no-wrap \
--sort-output \
--omit-header

The --omit-header can be omitted along with the last back slash for comparison purposes like in WinMerge.

As these strings will be sorted, it will be easy to compare *.po files between versions. Comments can be stripped with:

grep ^'^#' sourcefile.txt > output.txt