FrontAccounting forum — Missing function 'delete_image' when trying to delete an Item

Re: Missing function 'delete_image' when trying to delete an Item

null@example.com (apmuthu) — Tue, 25 Jan 2022 03:00:25 +0000

The committed fix now renames the function del_image to delete_image as used in the codebase. The re-run of the commit now changes the usage to del_image and rolls back the function name change.

This error in coding occurred as the earlier function name was used as the $_POST variable from the form.

Such usages are in some extensions as well - additional_fields and fronthrm but mostly as $_POST variables.

Re: Missing function 'delete_image' when trying to delete an Item

null@example.com (joe) — Mon, 24 Jan 2022 07:58:54 +0000

Fixed and committed to stable.

Thanks for finding this.

/Joe

Re: Missing function 'delete_image' when trying to delete an Item

null@example.com (apmuthu) — Mon, 24 Jan 2022 03:02:04 +0000

@joe: Kindly fix this.

Re: Missing function 'delete_image' when trying to delete an Item

null@example.com (apmuthu) — Sun, 23 Jan 2022 16:03:12 +0000

Looks like it should be del_image instead of delete_image.

The function is defined in inventory/manage/items.php at 59 to 67:

function del_image($stock_id)
{
    foreach (array('jpg', 'png', 'gif') as $ext) {
        $filename = company_path().'/images/'.item_img_name($stock_id).".".$ext;
        if (file_exists($filename) && !unlink($filename))
            return false;
    }
    return true;
}

Re: Missing function 'delete_image' when trying to delete an Item

null@example.com (apmuthu) — Sun, 23 Jan 2022 15:45:58 +0000

Which version of FA, PHP and MySQL are you using?

Line 338 of inventory/manage/items.php is:

        delete_image($stock_id);

The said function literal is absent in whole of the FA codebase and wonder how the image gets deleted.

Missing function 'delete_image' when trying to delete an Item

null@example.com (brucek@pelhamhs.org) — Sun, 23 Jan 2022 14:00:23 +0000

When I try to delete an item, it throws an error about a missing function:

Unhandled exception [0]: Call to undefined function delete_image(). in file: /xxx/xxx/fa/inventory/manage/items.php at line 338

It will still remove the item while throwing this error.
Thanks