FrontAccounting forum — qty_done is not updated correctly when partial invoice is voided

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (cedricktshiyoyo) — Sun, 03 Oct 2021 20:46:46 +0000

kvvaradha wrote:

cedricktshiyoyo wrote:
joe wrote:
Thanks @kvvaradha, I will fix and commit.
Joe
Why are you guys not considering the issue with fixed asset depreciation problems? The value is not correct... Who can assist correct this error.
@ap.muthu . The depreciation value is not correct with the rate provided. whether straight line or declining method. the book value is incorrect,
it seems like the focus is more given into sales and purchases, what about the other modules ?
Probably we need more clear explanation to implement a change in code. The straight line or decline method. Whatever it's. Explain the issue clearly with the calculation of sample.
If you are not interested to contribute the open source community, hire a freelancer and do that for you.
Most of the shouting users are not helping the community to grow.

I am not part of the shouting community, review my activities, you will see that i have a contribute in many areas. I am just trying to point out a error i have noticed, isn't a company asset management of a great importance?
I am just asking one thing, where the maths is happening when it comes to asset depreciation... The book value after depreciation is not correct according to the percentage you entered.

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (kvvaradha) — Sun, 26 Sep 2021 03:33:34 +0000

cedricktshiyoyo wrote:

joe wrote:
Thanks @kvvaradha, I will fix and commit.
Joe
Why are you guys not considering the issue with fixed asset depreciation problems? The value is not correct... Who can assist correct this error.
@ap.muthu . The depreciation value is not correct with the rate provided. whether straight line or declining method. the book value is incorrect,
it seems like the focus is more given into sales and purchases, what about the other modules ?

Probably we need more clear explanation to implement a change in code. The straight line or decline method. Whatever it's. Explain the issue clearly with the calculation of sample.

If you are not interested to contribute the open source community, hire a freelancer and do that for you.

Most of the shouting users are not helping the community to grow.

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (rafat) — Sun, 26 Sep 2021 03:00:36 +0000

@cedricktshiyoyo,
I think the developers are looking at experienced programmers like you to suggest a solution, This is what open source is all about. A community collaboration. So if you think you have a solution then suggest it. If they see it feasible they will include it. Also Fixed Assets is an optional module and the usage is not as much as Sales or Purchase..Its normal to have more focus on widely used modules. I don't see any bias between any of FA modules.

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (cedricktshiyoyo) — Sun, 26 Sep 2021 00:07:08 +0000

joe wrote:

Thanks @kvvaradha, I will fix and commit.
Joe

Why are you guys not considering the issue with fixed asset depreciation problems? The value is not correct... Who can assist correct this error.
@ap.muthu . The depreciation value is not correct with the rate provided. whether straight line or declining method. the book value is incorrect,
it seems like the focus is more given into sales and purchases, what about the other modules ?

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (joe) — Fri, 24 Sep 2021 15:23:49 +0000

Thanks @kvvaradha, I will fix and commit.

Joe

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (kvvaradha) — Fri, 24 Sep 2021 14:48:02 +0000

inside /sales/includes/db/sales_invoice_db.inc find line no around 260

update_parent_line($type, $row['id'], -$row['quantity']);

replace this with

update_parent_line($type, $row['id'], -$row['qty_done']);

actually we need to pass the quantity_done, not the original quantity

Re: qty_done is not updated correctly when partial invoice is voided

null@example.com (rafat) — Fri, 24 Sep 2021 03:31:48 +0000

Yes I can reproduce the above easily. FA2.4.10
I will post it in mantis.

qty_done is not updated correctly when partial invoice is voided

null@example.com (boxygen) — Thu, 23 Sep 2021 21:19:34 +0000

Create a Direct Delivery as below

https://prnt.sc/1tdjz2u

Create Partial Invoice of the Delivery as Below

https://prnt.sc/1tdk6yi

Now void this newly created invoice and then again create a Invoice for the delivery. You will find the wrong updated qty_done as below

https://prnt.sc/1tdkfp2