FrontAccounting forum — Item_units_db.inc file gives error with this functions

Re: Item_units_db.inc file gives error with this functions

2021-07-06T16:15:11Z

I will take a look into the new version.

Re: Item_units_db.inc file gives error with this functions

2021-07-06T07:25:42Z

This mission is now fixed and committed to stable repo. I hope all of them are taken, but please report any remains.

/Joe

Re: Item_units_db.inc file gives error with this functions

2021-07-05T21:20:25Z

After talking to Janusz, we can
change the line:

return $row[0];

to

return is_array($row) ? $row[0] : false;

This fixes the problem. But we don't have to do it all over the places. Only where there are NO aggregates as SUM, COUNT etc. These aggregates will always deliver at least one row with empty values.

I will start fixing the needed places tomorrow.

/Joe

Re: Item_units_db.inc file gives error with this functions

2021-07-05T06:17:54Z

ok Thanks @kvvaradha.

I will just have a short discussion with Janusz (itronics) about this mysqli issue, before trying to fix it.

I will fix the qty_cell error.

/Joe

Re: Item_units_db.inc file gives error with this functions

2021-07-05T05:36:33Z

@Joe both are same conditions, right?

Though i checked it again, still it passes to the next, db_fetch_row and gives error.

and also while checking this i found another issue in the sales_kit.php
line no 49

qty_cell($myrow["quantity"], false,     $myrow["units"] == '' ? 0 : get_qty_dec($myrow["comp_name"]));

and it has to pass the stock id instead of comp_name

qty_cell($myrow["quantity"], false,     $myrow["units"] == '' ? 0 : get_qty_dec($myrow["stock_id"]));

Re: Item_units_db.inc file gives error with this functions

2021-07-04T16:38:34Z

Did you also try:

if ($result == false)
    return false;

Joe

Re: Item_units_db.inc file gives error with this functions

2021-07-04T16:30:58Z

I tried this @joe, but the if condition didn't work.
though it goes to the next line and gives error.

Trying to access array offset on value of type bool in

Re: Item_units_db.inc file gives error with this functions

2021-07-03T21:09:01Z

@kvvaradha

Couldn't we just put these two lines after the query result:

if (!$result)
    return false;

Because if there is a $result then db_fetch will always return at least one array.

/Joe

Re: Item_units_db.inc file gives error with this functions

2021-07-03T18:06:41Z

Ok I will have a look at this.

Joe

Re: Item_units_db.inc file gives error with this functions

2021-07-03T17:09:00Z

All these

        return $row[0];

should be changed to

if(db_num_rows($result) > 0){
        $row = db_fetch_row($result);
        return $row[0];
    } else 
        return false;

Re: Item_units_db.inc file gives error with this functions

2021-07-03T17:06:49Z

kvvaradha wrote:

Sure @joe, I will list them and get you the list of changes.

Here is the total list of changes @joe. it comes with more files, i put a search list here.

/var/www/FA/2410/admin/db/security_db.inc:
   65:     return $row[0];

/var/www/FA/2410/admin/db/tags_db.inc:
   68:     return $row[0];
  108:     return $row[0];

/var/www/FA/2410/dimensions/includes/dimensions_db.inc:
  185:     return $row[0];

/var/www/FA/2410/fixed_assets/includes/fa_classes_db.inc:
   30:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_account_types.inc:
  101:     return $row[0];
  158:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_accounts.inc:
   88:         return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_bank_trans.inc:
  137:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_banking.inc:
  138:     return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_rates.inc:
   35:         return $row[0];

/var/www/FA/2410/gl/includes/db/gl_db_trans.inc:
  368:     return $row[0];
  426:     return $row[0];

/var/www/FA/2410/includes/dashboard.inc:
  851:     return $row[0];
  909:     return $row[0];
 1197:     return $row[0];
 1205:     return $row[0];
 1213:     return $row[0];
 1227:     return $row[0];
 1235:     return $row[0];
 1244:     return $row[0];
 1252:     return $row[0];
 1262:     return $row[0];
 1270:     return $row[0];
 1278:     return $row[0];
 1287:     return $row[0];
 1315:     return $row[0];
 1326:     return $row[0];
 1334:     return $row[0];
 1342:     return $row[0];
 1350:     return $row[0];
 1359:     return $row[0];
 1368:     return $row[0];
 1376:     return $row[0];
 1384:     return $row[0];
 1392:     return $row[0];
 1400:     return $row[0];
 1436:         return $row[0];
 1451:         return $row[0];
 1460:     return $row[0];

/var/www/FA/2410/includes/db/connect_db.inc:
   24:     return $row[0];

/var/www/FA/2410/includes/db/crm_contacts_db.inc:
  245:     return $row[0];

/var/www/FA/2410/includes/db/inventory_db.inc:
  170:     return $row[0];
  348:     return $row[0];
  497:         return $row[0];

/var/www/FA/2410/includes/db_pager.inc:
  352:             $this->rec_count = $row[0];

/var/www/FA/2410/inventory/includes/db/items_category_db.inc:
  101:     return $row[0];

/var/www/FA/2410/inventory/includes/db/items_units_db.inc:
   51:     return $row[0];
   75:     return $row[0];

/var/www/FA/2410/purchasing/includes/db/grn_db.inc:
  208:     return $row[0];

/var/www/FA/2410/purchasing/includes/db/suppliers_db.inc:
  147:     return $row[0];

/var/www/FA/2410/reporting/rep103.php:
  100:     return $row[0];

/var/www/FA/2410/reporting/rep205.php:
   56:     return $row[0];

/var/www/FA/2410/reporting/rep306.php:
   89:         return $row[0];

/var/www/FA/2410/reporting/rep310.php:
   90:         return $row[0];

/var/www/FA/2410/reporting/rep451.php:
   36:     return $row[0];

/var/www/FA/2410/reporting/rep601.php:
   39:     return $row[0];

/var/www/FA/2410/reporting/rep602.php:
   40:     return $row[0];

/var/www/FA/2410/sales/includes/db/cust_trans_db.inc:
  247:     return $row[0];

/var/www/FA/2410/sales/includes/db/customers_db.inc:
  135:     return $row[0];

/var/www/FA/2410/sales/includes/db/recurrent_invoices_db.inc:
   88:     return !$row[0];

/var/www/FA/2410/sales/includes/db/sales_delivery_db.inc:
  214:       else $freight = $row[0];

/var/www/FA/2410/sales/includes/db/sales_groups_db.inc:
   52:     return $row[0];
   95:     return $row[0];
  154:     return $row[0];

/var/www/FA/2410/sales/includes/db/sales_invoice_db.inc:
  294:     return $row[0];

/var/www/FA/2410/sales/includes/db/sales_order_db.inc:
  647:         return $row == false ? false : $row[0];

/var/www/FA/2410/sales/includes/db/sales_points_db.inc:
   64:     return $row[0];

/var/www/FA/2410/sales/includes/db/sales_types_db.inc:
   53:     return $row[0];

/var/www/FA/2410/sql/alter2.2.php:
   90:         $max_order = $row[0];

/var/www/FA/2410/taxes/db/tax_types_db.inc:
   76:     return $row[0];

Re: Item_units_db.inc file gives error with this functions

2021-06-28T10:17:37Z

kvvaradha wrote:

For straight line method, you need to use the purchase cost. so the purchase cost may be 15000 USD, this is a chance.
and probably you need to trace it with calculation from the compute_gl_rows_for_depreciation with some display errors placed in between locations i cant understand full concept of straight line method here programmed. it looks they are getting remaining months and process with new one. so in the each line place some display errors to make it readable for you.

I am not very good at Ajax, how do I replace the calculation of % to get the exact percent value of and asset after depreciation.

e.g: if I purchased my asset with 5000 USD, with 5% depreciation rate, I am expecting to get 250 usd depreciation after 1 year. and my book value will be 4750 USD.

THanks

Re: Item_units_db.inc file gives error with this functions

2021-06-28T02:41:50Z

For straight line method, you need to use the purchase cost. so the purchase cost may be 15000 USD, this is a chance.

and probably you need to trace it with calculation from the compute_gl_rows_for_depreciation with some display errors placed in between locations i cant understand full concept of straight line method here programmed. it looks they are getting remaining months and process with new one. so in the each line place some display errors to make it readable for you.

Re: Item_units_db.inc file gives error with this functions

2021-06-27T19:41:42Z

kvvaradha wrote:

Hello dude, May be it will be in the calculation issue, you need to describe, what comes and what you exactly need it with this code. describe that. We needs to understand it.

Hello, just forget about my code I was trying to use the fixed asset module, to register my assets, but when I process depreciation, the value is not correct according to the depreciation rate,

for example: when you register an asset with purchase value of 30,000 USD, with Straight Line depreciation rate of 5%. for the first year I am supposed to get 1500 USD and my book value should be 28,500 USD,
So instead i am getting depreciation value of 650 USD which is 2.2%,... WHERE DO YOU FIX THIS IN THE CODE for it to get the exact 5%

Re: Item_units_db.inc file gives error with this functions

2021-06-27T12:02:59Z

Hello dude, May be it will be in the calculation issue, you need to describe, what comes and what you exactly need it with this code. describe that. We needs to understand it.