FrontAccounting forum — FA 2.4.9 Login Error Msg

Re: FA 2.4.9 Login Error Msg

null@example.com (dyrandz) — Thu, 21 Jan 2021 15:31:10 +0000

It's working now

Thanks!

Re: FA 2.4.9 Login Error Msg

null@example.com (rafat) — Thu, 21 Jan 2021 07:19:50 +0000

Fixed by Janusz

https://sourceforge.net/p/frontaccounting/git/ci/e7fb3a02d86a3bc88387280561d802d4744e8885/

Re: FA 2.4.9 Login Error Msg

null@example.com (dyrandz) — Wed, 20 Jan 2021 01:38:41 +0000

Thanks tom

Re: FA 2.4.9 Login Error Msg

null@example.com (tom.horton) — Tue, 19 Jan 2021 19:35:13 +0000

This was in the file:

includes/session.inc

Line 556 onwards

Re: FA 2.4.9 Login Error Msg

null@example.com (dyrandz) — Tue, 19 Jan 2021 08:35:07 +0000

tom.horton wrote:

I have managed to isolate the problem. It seems that FA is picking up that a session is still active, from the following code:
if (isset($_SESSION['timeout'])) {
      include($path_to_root . "/access/login.php");
      exit;
} else
      login_fail();
}
This is despite you being logged out.
The only way I managed to fix it myself was by adding another condition to the IF statement:
if (isset($_SESSION['timeout']) && ($_SESSION['timeout'] == '')) {
      include($path_to_root . "/access/login.php");
      exit;
} else 
     login_fail();
}
There may be a better solution, but this was the only way I could get the system to pick up an error and show the user.
Hope this helps.

What file to add to this temporary fix?

Re: FA 2.4.9 Login Error Msg

null@example.com (rafat) — Sun, 17 Jan 2021 14:13:44 +0000

Done
http://mantis.frontaccounting.com/view.php?id=5322

Re: FA 2.4.9 Login Error Msg

null@example.com (tom.horton) — Sun, 17 Jan 2021 14:11:41 +0000

Definitely worth logging to see if a better solution can be found.

Re: FA 2.4.9 Login Error Msg

null@example.com (rafat) — Sun, 17 Jan 2021 14:05:49 +0000

This was introduced with 2.4.9 previous releases did not have this problem.
I will put this one in mantis.
Thx.. tom.horton

Re: FA 2.4.9 Login Error Msg

null@example.com (tom.horton) — Sun, 17 Jan 2021 13:34:51 +0000

I have managed to isolate the problem. It seems that FA is picking up that a session is still active, from the following code:

if (isset($_SESSION['timeout'])) {
      include($path_to_root . "/access/login.php");
      exit;
} else
      login_fail();
}

This is despite you being logged out.

The only way I managed to fix it myself was by adding another condition to the IF statement:

if (isset($_SESSION['timeout']) && ($_SESSION['timeout'] == '')) {
      include($path_to_root . "/access/login.php");
      exit;
} else 
     login_fail();
}

There may be a better solution, but this was the only way I could get the system to pick up an error and show the user.

Hope this helps.

Re: FA 2.4.9 Login Error Msg

null@example.com (rafat) — Sun, 17 Jan 2021 02:57:58 +0000

I also experienced same behavior of 2.4.9

FA 2.4.9 Login Error Msg

null@example.com (dyrandz) — Sun, 17 Jan 2021 02:38:01 +0000

Every time I input an incorrect password, I didn't see the error message. It will just get back to blank username and password field.

Regards
-Dyrandz