FrontAccounting forum — Item Adjustments Note disable rounding of Unit Cost

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (joe) — Fri, 18 Dec 2020 10:28:12 +0000

Hello and thanks to @islamsaeid3, @notrinos and @apmuthu for seeing this.

This has been fixed and committed to stable repo (?). I think we are close to a 2.4.10 release

You can download the fixed file here and replace in /inventory/includes/item_adjustments_ui.inc.

/Joe

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (apmuthu) — Fri, 18 Dec 2020 04:50:11 +0000

@joe: Please check and correct it:
Line 202 in inventory/includes/item_adjustments_ui.inc:

            amount_cells(null, 'std_cost', null, null, null, $dec);

needs to be replaced with:

            amount_cells(null, 'std_cost', null, null, null, $dec2);

This line was introduced in commit on 2019-06-28 as Line 194:
Inventory Adjustment: negative adjustment should always use current average item cost.

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (notrinos) — Fri, 18 Dec 2020 02:22:26 +0000

I confirm the rounding problem.
Fix: line 202 of item_adjustment_ui.inc should be

amount_cells(null, 'std_cost', null, null, null, $dec2);

The last passed variable should be $dec2 not $dec, $dec is for quantity decimal

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (apmuthu) — Thu, 17 Dec 2020 16:04:33 +0000

Try with FA 2.4.9+ and see if the issue persists.
Also, state your PHP/MySQL/Platform versions.

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (islamsaeid3) — Wed, 16 Dec 2020 19:25:35 +0000

Frontaccounting V 2.4.8
@joe @apmuthu

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (kvvaradha) — Wed, 16 Dec 2020 08:45:45 +0000

I am also unable to reproduce the issue. But I am strongly suggesting something to make changes In our program. As I seeing some of moderate companies are asking me why FA gives cost update entry by wrong. It happens because of the decimal values and we have double in MySql field type. That allows more decimal values to the system. That's really some dangerous values to a single item which definitely won't have that much huge value. I will get you the sample when I get similar scenario with clients. Usually the decimal values are not properly controlled from our side. We should make some changes for it.

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (joe) — Tue, 15 Dec 2020 17:22:12 +0000

I cannot reproduce this error. Which version?

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (apmuthu) — Tue, 15 Dec 2020 16:13:19 +0000

@joe: why is this?

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (kvvaradha) — Sat, 12 Dec 2020 13:35:17 +0000

Hello @islamsaeid3,

Its good to hear. I will check the function as well. Thank you.

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (islamsaeid3) — Sat, 12 Dec 2020 12:05:46 +0000

Hi Kvvaradha,

Thank you for your response. I tried this option by preferences but not solved..

I solved it by editing inventory/includes/item_adjustments_ui.inc like this:

Replace this code:

amount_cells(null,'std_cost',null,null,null,$dec);

with:

amount_cells(null,'std_cost');

It has worked for me.

Re: Item Adjustments Note disable rounding of Unit Cost

null@example.com (kvvaradha) — Tue, 08 Dec 2020 19:24:21 +0000

There is rounding option available in Preference page. Did you change it to apply more. So it would affect here better..

Item Adjustments Note disable rounding of Unit Cost

null@example.com (islamsaeid3) — Tue, 08 Dec 2020 14:02:08 +0000

Hi Every one
At the first, I would like to thank you for the great effort that you have made to develop this great software .. When I read your blogs about what you have faced in terms of issues and how to communicate to find solutions and provide support, you made me proud of you all.
Secondly, i'm asking your help and support to solve this Issue :
1-Open Inventory Module.
2-Open Inventory Adjustments.
3-Select item and fill QTY.
4- Fill Unit Cost by 100.56 But system rounding Unit cost automaticly to 101
So Kindly suuport me to disable Auto Rounding for Unit cost on Item Adjustment Note.
your quick response is appreciated.
Regards