FrontAccounting forum — bug in purchase order delete when invoking hook_db_prevoid ()

Re: bug in purchase order delete when invoking hook_db_prevoid ()

null@example.com (anoopmb) — Tue, 29 Sep 2020 05:02:12 +0000

Thanks @Joe, @Varadha

I have been facing issue while creating modules related to purchase.

null@example.com (joe) — Sat, 26 Sep 2020 08:00:04 +0000

Fixed and committed to stable repo.

/Joe

null@example.com (kvvaradha) — Sat, 26 Sep 2020 05:07:07 +0000

@anoopmb you are right. This is a bug. @Joe fix it. By changing the parameter location.

null@example.com (joe) — Sat, 26 Sep 2020 05:03:26 +0000

I will have a look at this.

Joe

null@example.com (dearmosin) — Fri, 25 Sep 2020 23:05:53 +0000

@anoopmb: I found this function in includes/hooks.inc

This database transaction hooks are for modules to invoked before transaction is voided

function hook_db_prevoid($type, $type_no)
{
    return hook_invoke_all('db_prevoid', $type, $type_no);
}

Where $type is type of transaction like ST_PURCHORDER. Which mean first parameter must be ST_PURCHORDER.

So your correct, but @joe or @apmuthu may provide more information on this.

Regards

null@example.com (anoopmb) — Wed, 23 Sep 2020 21:49:06 +0000

Hi,

I found a bug in delete_po($po) function

hook_db_prevoid($po, ST_PURCHORDER);

it has to be

hook_db_prevoid(ST_PURCHORDER, $po);

please correct me, if i am wrong