What is the best way to backup and restore these changes when a new version becomes available? I imagine some of the changes I made to 2.4.7 may already be incorporated in the next version.
]]>I have no problem adding a journal entry to clean up. I was more concerned that I was doing something wrong or I setup something wrong and I wanted to correct that. Maybe most people just let this run wild and don't address it at all. I'm not trying to make more work to do, just wanting to follow best practices with the tools available.
Thank you very much for the insight and suggestions.
]]>/Joe
]]>When FA closes a work order, it calls work_order_produce() which first creates the Finished Product Requirements. The g/l created by each requirement eventually calls add_gl_trans(). Note the rounding in this function:
function add_gl_trans($type, $trans_id, $date_, $account, $dimension, $dimension2, $memo_,
$amount, $currency=null, $person_type_id=null, $person_id=null, $err_msg="", $rate=0)
{
global $SysPrefs;
$date = date2sql($date_);
if ($currency != null)
{
if ($rate == 0)
$amount_in_home_currency = to_home_currency($amount, $currency, $date_);
else
$amount_in_home_currency = round2($amount * $rate, user_price_dec());
}
else
$amount_in_home_currency = round2($amount, user_price_dec());OK, so each requirement is rounded, and then added up.
But wait, there is more to do. work_order_produce() then sums up the Finished Product Recieval:
// 1. calculate sums of material/labour/overhead costs
// sum collected BOM material & labour costs (no way for separate overhead here for now - needs flag in bom or stock_master)
$bom = get_wo_requirements($woid);
$m_cost = $l_cost = 0;
while ($component = db_fetch($bom))
{
if (!is_service($component["mb_flag"]))
$m_cost += $component['unit_cost']*$component['units_issued'];
else
$l_cost += $component['unit_cost']*$component['units_issued'];
}
// add additional material issues
$issues = get_additional_issues($woid);
while ($issue = db_fetch($issues))
{
if (!is_service($issue["mb_flag"]))
$m_cost += $issue['unit_cost']*$issue['qty_issued'];
else
$l_cost += $issue['unit_cost']*$issue['qty_issued'];
}
// and additional costs
$o_cost = get_gl_wo_cost($woid, WO_OVERHEAD);
$l_cost += get_gl_wo_cost($woid, WO_LABOUR);
$total_cost = $o_cost + $m_cost + $l_cost;
add_gl_trans_std_cost(ST_WORKORDER, $woid, $date_, $product['wip_account'],
0, 0, $memo, -$total_cost);
add_gl_trans_std_cost(ST_WORKORDER, $woid, $date_, $product['inventory_account'],
0, 0, $memo, $total_cost);So if all units were able to be manufactured, the calculation should be the same.
Except for the lack of rounding in this code.
So if it disturbs you to see these rounding errors, what can you do? Well, you could try rounding m_cost and l_cost like in add_gl_trans. Maybe try:
if (!is_service($issue["mb_flag"]))
$m_cost += round2($issue['unit_cost']*$issue['qty_issued'], user_price_dec());
else
$l_cost += round2($issue['unit_cost']*$issue['qty_issued'], user_price_dec());I haven't tried this, so it might not work. But this is first thing I would try.
]]>1.7 is NOT greater than or equal to 1.7000000000000002
0.30000000000000004I don't need super fine precision. I would like consistency. If I'm taking $33.01 out of inventory for manufacturing, I need $33.01 taken from manufacturing back into inventory. Maybe part of my problem is the difference from my vendors unit of 1 equals 1152 units in my inventory. Standard costs are shown at 4 decimal places.
]]><?php
if (1.7 >= 17 * 0.1) {
echo '1.7 is greater than or equal to ' . 17 * 0.1;
} else {
echo '1.7 is NOT greater than or equal to ' . 17 * 0.1;
}
echo "<br>\n" . (0.1 + 0.2);
?>In XAMPP 1.7.3 (PHP 5.3.1) we get:
1.7 is NOT greater than or equal to 1.7000000000000002
0.30000000000000004This is because native operator are indeed interpreted in base 2, and most base 10 decimal converts badly in base 2.
If you need precision, you need to either only manipulate integers (converts perfectly to base 2) or use a dedicated lib such as bcmath (checkout the wrapper to ease bcmath usage Math).
Ref as of 2 months ago:
https://stackoverflow.com/questions/58744298/php-floating-point-multiplication-and-comparison-issue
Ref as of nearly 11 years ago:
https://stackoverflow.com/questions/588004/is-floating-point-math-broken
Ref in PHP.net:
https://bugs.php.net/bug.php?id=74534