FrontAccounting forum — Purchase Order Report rep209

Re: Purchase Order Report rep209

null@example.com (notrinos) — Thu, 16 Jan 2020 17:05:05 +0000

Hello @apmuthu these reports do not have this problem.
These constructs are not uniform due to our lack of a codding standard.
A few sql queries return value outside of database and others don't

Re: Purchase Order Report rep209

null@example.com (apmuthu) — Thu, 16 Jan 2020 14:24:49 +0000

The same construct is seen in

reporting/rep107.php
reporting/rep110.php
reporting/rep113.php
includes/ui/ui_view.inc

@joe: Do any of these reports or file show the same effect?

Re: Purchase Order Report rep209

null@example.com (joe) — Thu, 16 Jan 2020 08:22:36 +0000

This has been fixed and committed to 2.4.7 stable repo. A fixed file can be downloaded here.

/Joe

Re: Purchase Order Report rep209

null@example.com (apmuthu) — Wed, 15 Jan 2020 23:34:06 +0000

@joe: what should change and where (earlier or later) - should this be committed?

Re: Purchase Order Report rep209

null@example.com (rafat) — Wed, 15 Jan 2020 03:13:48 +0000

Thanks @notrinos
You are right.. maybe we need to commit this one.

Re: Purchase Order Report rep209

null@example.com (notrinos) — Tue, 14 Jan 2020 17:13:05 +0000

Hello rafat, code block from line 179 to 182 should be replaced with only one line:

$tax_type_name = $tax_item['tax_type_name'];

Since the function get_tax_group_rates() in tax_group_db.inc has already check the suppress_tax_rates status so dont need to check again.
See the difference in the attached below

Purchase Order Report rep209

null@example.com (rafat) — Tue, 14 Jan 2020 12:18:34 +0000

In rep209 the Tax rate is displayed twice in succession i.e Tax(5%)(5%). I dont know how to correct it.
Can someone help me here.
Image attached.
FA2.4.7