FrontAccounting forum — Arabic RTL PDF Reports

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Sun, 18 Aug 2019 14:30:29 +0000

Tested the fix and its OK.

Re: Arabic RTL PDF Reports

null@example.com (apmuthu) — Sun, 18 Aug 2019 05:52:15 +0000

Re: Arabic RTL PDF Reports

null@example.com (poncho1234) — Fri, 16 Aug 2019 14:30:03 +0000

Glad you got it sorted, not sure if this is bug or as designed; it does seem a little incomplete that rtl just defaults all Textwrap alignments to right align though, I'll add it to mantis

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Fri, 16 Aug 2019 12:21:36 +0000

And this is rep108

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Fri, 16 Aug 2019 12:18:11 +0000

Hi,

Tested reports and seem all OK for me at least.. here are some samples of rep107 and rep108

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Fri, 16 Aug 2019 01:58:48 +0000

@poncho1234

Thanks for your guidance.. much appreciated. What worked for me is to comment the else statement at the end..I dont know what is it for. The rest I did not touch ..even the C in header2.inc stayed the same .. Changing it to L, R also works as expected.

if (!$this->rtl)
        {
            if ($align == 'right')
                $align = 'R';
            elseif ($align == 'left')
                $align = 'L';
            elseif ($align == 'center')
                $align = 'C';
            elseif ($align == 'justify')
                $align = 'J';
        }
        // else
        //    $align = 'R';

I dont know if this is a permanent solution or it might affect other things.. I tested with different reports and looks fine to me.
Statement Report has a minor issue . I will look into it.

Re: Arabic RTL PDF Reports

null@example.com (poncho1234) — Thu, 15 Aug 2019 17:00:05 +0000

@rafat, your not touching tcpdf core, your editing \reporting\includes\class.pdf.inc

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Thu, 15 Aug 2019 16:28:53 +0000

@poncho1234

Give me some time to experiment this... as we are touching tcpdf core .. which (supposedly) is very stable and is working OK for all.

I will come back to you soon.

Thx.

Re: Arabic RTL PDF Reports

null@example.com (poncho1234) — Thu, 15 Aug 2019 15:02:08 +0000

1. Are you sure you only have one copy of header2.php(Check in the company folder)

2. Tracing the Textwrap function back to getCellCode:-

File: \reporting\includes\tcpdf.php

2993:                 if ($align == 'L') {
2994:                     if ($this->rtl) {
2995:                         $dx = $w - $width - $this->cMargin;
2996:                     } else {
2997:                         $dx = $this->cMargin;
2998:                     }
2999:                 } elseif ($align == 'R') {
3000:                     if ($this->rtl) {
3001:                         $dx = $this->cMargin;
3002:                     } else {
3003:                         $dx = $w - $width - $this->cMargin;
3004:                     }
3005:                 } elseif ($align == 'C') {
3006:                     $dx = ($w - $width) / 2;
3007:                 } elseif ($align == 'J') {
3008:                     if ($this->rtl) {
3009:                         $dx = $w - $width - $this->cMargin;
3010:                     } else {
3011:                         $dx = $this->cMargin;
3012:                     }

Option 'C' does not have a if ($this->rtl) statement so 'C' should have no difference in RTL or LTR

So 2a. Logout, Delete all cache in company folder, delete browser cache(Pref change browser) log back in.

2.b In function Textwrap a function addTextWrap is called, part of function below:-

File: \reporting\includes\class.pdf.inc

294:     function addTextWrap($xb, $yb, $w, $h, $txt, $align='left', $border=0, $fill=0, $link = NULL, $stretch = 1, $spacebreak=false)
295:     {
296:         $ret = "";
297:         if (!$this->rtl)
298:         {
299:             if ($align == 'right')
300:                 $align = 'R';
301:             elseif ($align == 'left')
302:                 $align = 'L';
303:             elseif ($align == 'center')
304:                 $align = 'C';
305:             elseif ($align == 'justify')
306:                 $align = 'J';
307:         }
308:         else
309:             $align = 'R';

this seems to be expecting the $align variable to be either 'right', 'left', 'justify', 'center'; not R, L, J, or C.

So in header2.php try this:-

$this->TextWrap($col, $this->row, $width, $info_header, 'center');

Delete cache etc

Post back results please

Edit it also states that if rtl everything will be R so try changing the else part to this:-

297:         if (!$this->rtl)
298:         {
299:             if ($align == 'right')
300:                 $align = 'R';
301:             elseif ($align == 'left')
302:                 $align = 'L';
303:             elseif ($align == 'center')
304:                 $align = 'C';
305:             elseif ($align == 'justify')
306:                 $align = 'J';
307:         }
308:         else
            {
                 if ($align == 'right')
                     $align = 'R';// This may need to be 'L'
                 elseif ($align == 'left')
                     $align = 'R';
                 elseif ($align == 'center')
                     $align = 'C';
                 elseif ($align == 'justify')
                     $align = 'J';
             }

You may need to change
if ($align == 'right')
$align = 'R';
to
if ($align == 'right')
$align = 'L';

Note you will need to use:-

$this->TextWrap($col, $this->row, $width, $info_header, 'center');

in header2.php for this to work

Also this will affect all ten of the print documents please check all of them: Please pay special attention to Report 108 (Print statements) As Textwrap is called an additional two times.

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Thu, 15 Aug 2019 09:38:06 +0000

The Arabic file.

Please look at the footer as well..

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Thu, 15 Aug 2019 09:37:02 +0000

Thanks guys,

@boxygen I tried with the new reporting folder but no luck. Same issue.
@poncho1234 I am attaching the same report (rep107) both when English is selected and when Arabic is selected. I highlighted the difference in yellow.

Re: Arabic RTL PDF Reports

null@example.com (boxygen) — Thu, 15 Aug 2019 02:29:04 +0000

@rafat you can try on this new reporting folder

https://frontaccounting.com/punbb/viewt … 223#p35223

Re: Arabic RTL PDF Reports

null@example.com (poncho1234) — Wed, 14 Aug 2019 16:14:58 +0000

@Rafat, Look at a LTR report in the mirror, take a pic; then compare it with your RTL report, highlight differences and post both pics

Note that the FA version of TCPDF is quite dated, there may well be RTL bugs in previous versions. Maybe try the latest version - TCPDF github tcpdf.php, but this may give you more problems than are resolved. But if it does fix the problem at least you know there is a fix - then compare old and new versions. Remember to rename the original tcpdf.php version.

Re: Arabic RTL PDF Reports

null@example.com (rafat) — Wed, 14 Aug 2019 13:28:14 +0000

Not all the report in LTR is left aligned. The middle part (Between the Company Name and email ..etc and the Bill of Material Details) Is what is called Auxiliary document information is centered as described in header2.inc

     // Auxiliary document information
        $col = $this->leftMargin;
        foreach($aux_info as $info_header => $info_content)
        {

            $this->row = $iline2 - $this->lineHeight - 1;
            $this->TextWrap($col, $this->row, $width, $info_header, 'C');
            $this->row = $iline3 - $this->lineHeight - 1;
            $this->TextWrap($col, $this->row, $width, $info_content, 'C');
            $col += $width;
        }

The TextWrap(.....$info_header, 'C') means centered. If I change the 'C' to 'L' it goes left or 'R' it goes right.. only if the language is NOT RTL. If the language is English then it behaves according to the choice I made. Arabic always right aligned.

There must be a catch somewhere ..

Re: Arabic RTL PDF Reports

null@example.com (poncho1234) — Wed, 14 Aug 2019 11:34:37 +0000

Documents in LTR are not centered, the Company name, email etc is aligned left, it is a mirror image of the pdf you have attached.