It's working as expected now.

Things are working as expected...

For filetype length I temporarily (awaiting 2.5) increased it to 80 from 60 and it seems OK.

ALTER TABLE `0_attachments` CHANGE `filetype` `filetype` VARCHAR(80) CHARACTER SET utf8 COLLATE utf8_unicode_ci NULL DEFAULT NULL;

Thanks for the fix. But in the three mentioned files 'false'/'true' string appears in completely different context i.e. as text representation of boolean value, so there s no need for change here.

@rafat
I will fix those issues too.

Thanks ,.. its working fine now.

Two minor things still needs addressing;

1) Mime (filetype) length for MS Office docs needs increasing.
2) In Setup->Attach Documents->Supplier/Customer if one does not choose a customer/supplier the system continues with no warning/error. Maybe a message needs to popup to enter a customer / supplier first.

The use of the string 'false' instead of the boolean false and the out of order include have contributed to the problem and has been rectified in the attachment which includes the diff file and the screenshot of successful addition of new supplier.

A few more files (need to properly check on what has worked till now anyway) that have this kind of construct (and 'true' as well) are:

reporting/includes/fpdi/pdf_parser.php
reporting/includes/tcpdf.php
includes/JsHttpRequest.php

@itronics / @joe: can commit it.

Sorry....I refer to supplier.....doesn't save new supplier!!!!

Customer is ok...as Apmuthu say.

See screenshots attached.

Provide more information regarding your issue with debug and sql_trails along with platform versions.

Thanks for the excellent job to make possible this funcionality. 

Trying to add a new customer it's not possible with the files downloaded.   Please fix it........

This is so because, the former uses a "button" tag whilst the latter uses the "a href" tag.

# Setup => Attachments (needs popup exception for FA domain)
# Sales => Add/Manage Customer => Attachments (no need for pop settings)

The HTML code inspection reveals the Concerned Lines:
# Lines 199 and 227 in admin/attachments.php

<td><button type="submit" class="editbutton" name="view3" value="1" title="View">
<img src="../themes/default/images/view.gif" 
     style="vertical-align:middle;width:12px;height:12px;border:0;">
</button>
</td>

# Line 95 in includes/ui/attachments.inc

<td style="text-align: center;">
<a target="_blank" class="viewlink" 
   href="../../admin/attachments.php?vw=3" 
   onclick="javascript:openWindow(this.href,this.target); return false;" 
   accesskey="V">
<img src="../../themes/default/images/view.gif" 
     style="vertical-align:middle;width:12px;height:12px;border:0;">
</a>
</td>

Commits:
https://github.com/FrontAccountingERP/FA/commit/3d95c6844745f183ebab970251cd254dd6cbdcec
https://github.com/FrontAccountingERP/FA/commit/15576cedd9e46caac2884c2815875e7ec9fd4802

Attached are the changed files for FA 2.4.7+ as on date.

Those who have used the old code will need to take note of:

Known issues:

1. Attaching MS Office documents like docx, xlsx, pptx, etc will result in error as the mime type exceeds 60 characters - need to increase the size of the field attachments.filetype to say 100 from the current 60 characters.

2. Edit of the attachment record in Sales => Add and Manage Customers => Attachments tab does not work as yet.

Theres are some errore when editing attachments. Say this.....

Undefined index: type_no
Undefined index: trans_no
Undefined index: title
Undefined index: filename
Undefined index: date

In this files...................../includes/ui/simple_crud_class.inc .......En la línea 258

and this error .......

Undefined index: date........in this file........../includes/ui/attachment.inc ..........En la línea 118
Undefined index: title.........in this file........./includes/ui/attachment.inc ...........En la línea 119

There is an error somehow in 247 when attaching an MS Office files like .docx. It does not attach and error log has the following:

<b>DATABASE ERROR :</b> Attachment could not be inserted<br>error code : 1406<br>error message : Data too long for column 'filetype' at row 1.

Its working OK with 246.