FrontAccounting forum — Add input data check for Gl Setup

Re: Add input data check for Gl Setup

null@example.com (joe) — Tue, 20 Nov 2018 09:54:08 +0000

I will have a look.

Joe

Re: Add input data check for Gl Setup

null@example.com (notrinos) — Tue, 20 Nov 2018 07:05:14 +0000

Should we add this modification to the next release also ?
https://frontaccounting.com/punbb/viewtopic.php?id=7764

Re: Add input data check for Gl Setup

null@example.com (joe) — Mon, 19 Nov 2018 05:45:39 +0000

We are planning a minor 2.4.5 release soon.

We just have to examine the Mantis Bug Tracker.

Joe

Re: Add input data check for Gl Setup

null@example.com (apmuthu) — Mon, 19 Nov 2018 03:25:31 +0000

A generic function encapsulating the error displayed and the checks may be in order. This may need to be done in a multitude of forms bloating the codebase otherwise.

@joe: There have been more than 50 commits since the last version release over 6 months ago - time for a another one with all translation strings as well?

Re: Add input data check for Gl Setup

null@example.com (joe) — Sun, 18 Nov 2018 22:01:14 +0000

This has now been fixed and committed to stable repo. Thanks @notrinos.

The fixed file can be downloaded here.

Joe

Re: Add input data check for Gl Setup

null@example.com (joe) — Sun, 18 Nov 2018 15:12:03 +0000

Ok, willdo.

Joe

Add input data check for Gl Setup

null@example.com (notrinos) — Sun, 18 Nov 2018 12:48:31 +0000

Should add these checks for function can_process() gl_setup.php

if (!check_num('past_due_days', 0, 100))
    {
        display_error(_("The past due days interval allowance must be between 0 and 100."));
        set_focus('past_due_days');
        return false;
    }

    if (!check_num('default_quote_valid_days', 0))
    {
        display_error(_("Quote Valid Days is not valid number."));
        set_focus('default_quote_valid_days');
        return false;
    }

    if (!check_num('default_delivery_required', 0))
    {
        display_error(_("Delivery Required By is not valid number."));
        set_focus('default_delivery_required');
        return false;
    }

    if (!check_num('default_receival_required', 0))
    {
        display_error(_("Receival Required By is not valid number."));
        set_focus('default_receival_required');
        return false;
    }

    if (!check_num('default_workorder_required', 0))
    {
        display_error(_("Work Order Required By After is not valid number."));
        set_focus('default_workorder_required');
        return false;
    }