FrontAccounting forum — reports_classes.inc:40: count()

Re: reports_classes.inc:40: count()

null@example.com (apmuthu) — Sun, 06 Oct 2019 10:01:04 +0000

All reporting/repXXX.php files call the reporting/includes/pdf_reports.inc based on destination chosen in the report request form.

All reporting/repXXX.php files are called only from reporting/reports_main.php which in turn "includes" the includes/ui.inc and that in turn "includes" the includes/ui/ui_globals.inc file (among others) that defines the function count_array().

Hence no need for separate inclusion of includes/ui/ui_globals.inc except when the reports are used independent of the above file.

Wonder why Line 374 was left out from such a change in reporting/includes/pdf_report.inc.

        $count = count($this->headers2);

Re: reports_classes.inc:40: count()

null@example.com (joe) — Sun, 06 Oct 2019 08:06:30 +0000

We only need to include the 2 changes made by @notrinos.
The inclusion of the ui_globals.inc has already been done in other places.

Committed to repo 2.4.7 stable.

/Joe

Re: reports_classes.inc:40: count()

null@example.com (apmuthu) — Sat, 05 Oct 2019 18:15:02 +0000

Search for "count(" in the reporting/includes/pdf_report.inc and we find 15 occurrences that need to be replaced with "count_array("

@joe: can commit this along with the inclusion of includes/ui/ui_globals.inc in it.

Re: reports_classes.inc:40: count()

null@example.com (notrinos) — Sat, 05 Oct 2019 13:10:39 +0000

pdf_report.inc lines 344 and 379 may need count_array() also.
And includes/ui/ui_globals.inc has to be included here since function count_array() is defined there.

Re: reports_classes.inc:40: count()

null@example.com (joe) — Thu, 29 Nov 2018 13:20:24 +0000

These files have been committed to stable repo. Just replace the count() with count_array() in both places.

Thanks @notrinos for finding these.

Please continue testing. Thanks in advance.

/Joe

Re: reports_classes.inc:40: count()

null@example.com (notrinos) — Thu, 29 Nov 2018 09:43:10 +0000

There are still some where

/includes/ui/items_cart.inc line 312. Error firing on Modifying Journal Transaction
/includes/ui/contacts_view.inc line 137. Error firing on Add Customer Contact without selecting Contact Category

Re: reports_classes.inc:40: count()

null@example.com (joe) — Thu, 29 Nov 2018 08:37:50 +0000

I have now committed a fix, where the count() was replaced with count_array(). It was only needed in 3 files and the count_array() was added at the end in the file /includes/ui/ui_globals.inc.

The files are:
/admin/db/maintenance_db.inc(186): $cnt = max(1, count_array($db_connections));
/reporting/includes/reports_classes.inc(37): $class_id = count_array($this->ar_classes);
/sales/includes/sales_db.inc(371): if (!count_array($trans_no))

and the count_array definition:
/includes/ui/ui_globals.inc(65): function count_array($array)

I have been testing FA all over, but I will ask you who has the PHP 7.2.X installed to download a snapshot of 2.4.4 from the repo here.

There was also a problem with the 2.nd parameter in number_format2 in the file /includes/current_user.inc. We used a float value as an integer parameter. Fixed with intval().

Please help me test this snapshot so we can find more odd count() and other problems.

Thank you in advance.

Joe

Re: reports_classes.inc:40: count()

null@example.com (apmuthu) — Thu, 29 Nov 2018 03:58:30 +0000

Yes, they are part of the Advanced PHP debugger.

Re: reports_classes.inc:40: count()

null@example.com (joe) — Wed, 28 Nov 2018 22:26:39 +0000

I see that the functions rename_function and override_function are not part of the standard PHP and therefore can not be used.

I will follow @cleal example and review all the count() calls. Where the check is needed I will use the count_array() instead of count().

Joe

Re: reports_classes.inc:40: count()

null@example.com (apmuthu) — Wed, 28 Nov 2018 16:26:00 +0000

@joe: Line 186 in admin/db/maintenance_db.inc can be preceded with:

if (!(is_array($db_connections)) $db_connections = array($db_connections);

Re: reports_classes.inc:40: count()

null@example.com (joe) — Wed, 28 Nov 2018 16:20:22 +0000

I will test a solution with rename_function and override_function.
We will include a new file with specific functions with new behaviors if
version_compare >= 7.2.0

Then we do not need to change anything in the code.

Joe

Re: reports_classes.inc:40: count()

null@example.com (notrinos) — Wed, 28 Nov 2018 14:55:20 +0000

Line 186 file maintenance_db.inc also needs array check function.
Error raising on Installation Wizard step 5.

Re: reports_classes.inc:40: count()

null@example.com (cleal) — Wed, 31 Oct 2018 20:27:43 +0000

I think, into /includes/ui/ one file named like that. In this add all functions to fix issues of deprecated functions or fix others.

And then, add include into /includes/ui.inc

Re: reports_classes.inc:40: count()

null@example.com (apmuthu) — Wed, 31 Oct 2018 18:47:38 +0000

All such PHP 7.x gotchas can be made into a separate php7.php file to be included if a PHP7.x version is in use.

Re: reports_classes.inc:40: count()

null@example.com (joe) — Wed, 31 Oct 2018 06:12:21 +0000

Yes maybe a good idea.

Joe