All reporting/repXXX.php files are called only from reporting/reports_main.php which in turn "includes" the includes/ui.inc and that in turn "includes" the includes/ui/ui_globals.inc file (among others) that defines the function count_array().

Hence no need for separate inclusion of includes/ui/ui_globals.inc except when the reports are used independent of the above file.

Wonder why Line 374 was left out from such a change in reporting/includes/pdf_report.inc.

        $count = count($this->headers2);

Committed to repo 2.4.7 stable.

/Joe

@joe: can commit this along with the inclusion of includes/ui/ui_globals.inc in it.

Thanks @notrinos for finding these.

Please continue testing. Thanks in advance.

/Joe

1. /includes/ui/items_cart.inc line 312. Error firing on Modifying Journal Transaction

2. /includes/ui/contacts_view.inc line 137. Error firing on Add Customer Contact without selecting Contact Category

The files are:
/admin/db/maintenance_db.inc(186): $cnt = max(1, count_array($db_connections));
/reporting/includes/reports_classes.inc(37): $class_id = count_array($this->ar_classes);
/sales/includes/sales_db.inc(371): if (!count_array($trans_no))

and the count_array definition:
/includes/ui/ui_globals.inc(65): function count_array($array)

I have been testing FA all over, but I will ask you who has the PHP 7.2.X installed to download a snapshot of 2.4.4 from the repo here.

There was also a problem with the 2.nd parameter in number_format2 in the file /includes/current_user.inc. We used a float value as an integer parameter. Fixed with intval().

Please help me test this snapshot so we can find more odd count() and other problems.

Thank you in advance.

Joe

I will follow @cleal example and review all the count() calls. Where the check is needed I will use the count_array() instead of  count().

Joe

Then we do not need to change anything in the code.

Joe

And then, add include into /includes/ui.inc

Joe