FrontAccounting forum — Error line break on supplier_list_cells when label is set to null

Re: Error line break on supplier_list_cells when label is set to null

null@example.com (joe) — Sat, 15 Sep 2018 08:26:03 +0000

This has been fixed and committed.
Thanks guys.

/Joe

Re: Error line break on supplier_list_cells when label is set to null

null@example.com (joe) — Fri, 14 Sep 2018 16:20:36 +0000

You are great guys! Will fix this later.

Joe

Re: Error line break on supplier_list_cells when label is set to null

null@example.com (kvvaradha) — Fri, 14 Sep 2018 15:18:25 +0000

True, But we mostly use supplier list cell with label. May be it will help to improve the code issues. if someone uses without label..
Instead of

echo "$label\n";

Replace with

 echo "$label\n";
        echo "";

Error line break on supplier_list_cells when label is set to null

null@example.com (notrinos) — Fri, 14 Sep 2018 14:03:32 +0000

If call function supplier_list_cells with label set to null then the inactive check cell will be pushed down.
This can be tested on supplier.php with label modified to null on line 292.
Solution: function supplier_list_cells of ui_list.inc should be

function supplier_list_cells($label, $name, $selected_id=null, $all_option=false, 
    $submit_on_change=false, $all=false, $editkey = false)
{
    if ($label != null)
        echo "$label\n";
        echo "";
        echo supplier_list($name, $selected_id, $all_option, $submit_on_change, 
        $all, $editkey);
        echo "\n";
}