FrontAccounting forum — A function line misplaced

Re: A function line misplaced

null@example.com (joe) — Thu, 23 Aug 2018 08:21:15 +0000

This item has been rolled back due to new bugs in the fixed solution.

Committed with whitespace fixes.

/Joe

Re: A function line misplaced

null@example.com (apmuthu) — Wed, 22 Aug 2018 15:45:53 +0000

Looks like a rollback of this commit is in order if no new workaround is found.

Re: A function line misplaced

null@example.com (apmuthu) — Fri, 17 Aug 2018 06:10:14 +0000

@joe: the whole commit can be reviewed instead of the fixed part alone.

A function line misplaced

null@example.com (kvvaradha) — Thu, 16 Aug 2018 12:41:04 +0000

From this commit

The function was misplaced. It was like this now.

https://github.com/kvcodes/FA/commit/42751ff1e05ac803548a07d412f4a173cd0e0450

if ($order->fixed_asset)
            stock_disposable_fa_list_cells(null,'stock_id', null, _('[Select item]'), true, $order->line_items);
        else
        if (list_updated('stock_id')) {
                            sales_items_list_cells(null,'stock_id', null, false, true, true);

And it should be like this.

if ($order->fixed_asset)
            stock_disposable_fa_list_cells(null,'stock_id', null, _('[Select item]'), true, $order->line_items);
        else
            sales_items_list_cells(null,'stock_id', null, false, true, true);
        if (list_updated('stock_id')) {