FrontAccounting forum — Print Invoice Bug

Re: Print Invoice Bug

2017-12-17T08:27:00Z

I think using the latest exchange rate in the exchange_rates.php page is great.

Re: Print Invoice Bug

2017-12-17T04:48:44Z

Is there a weblink / service / CSV available for middle rates for each day - archives of exchange rates - so that when a date range for a currency pair is requested, it can provide rates to populate the FA exchange rates table directly for that entire period. Also for rare significant rate changes, can the last populated rate not be taken instead?

Re: Print Invoice Bug

2017-12-16T19:54:45Z

This would fully resolve it, mine is work arround. In fact only invoicing dates are needed. It is already there for non default currencies...

Re: Print Invoice Bug

2017-12-16T18:40:16Z

Better still, populate the exchange rate for the currency desired into the exchange rates table for every day in the year.

Re: Print Invoice Bug

2017-12-16T17:48:14Z

@stefan
yes.. thats such a great idea and would work perfectly.

Re: Print Invoice Bug

2017-12-16T17:26:29Z

@Alaa, if I really understand your need, your biggest problem is the exchange rate on the date of invoice (if it's not stored for some other invoice).
An easy work arround would be if you change the function of the "Comments:" param in your changed report and manually input the exchange rate there. Of course some code changes are needed too.
Than you can make it work relatively well (it will not folow the rate changes of the selected period, if there are some). In fact the manual input can be used only for blank dates.
It will not be stored, just used to print or e-mail what you need.
I guess it is an issue of headquartes with other currency???

Re: Print Invoice Bug

2017-12-16T03:12:03Z

This version of the Invoice Report script - rep107.php - stands committed in my FA24Mods repo.

Re: Print Invoice Bug

2017-12-16T02:33:00Z

The customer filter remains so even in my code but does that determine the currency as well? Anyone using the filters, be it customer and / or currency will know what to expect of the results of the output subset. The changes in the code here will not affect any other report as it is localised only.

Yes, it is not a big deal. We can leave it as is and the code here can be used at will by those who need it - maybe I will put it in my FA24Mods.....

Re: Print Invoice Bug

2017-12-15T17:10:58Z

Yes, but you need a customer filter as well. The algorithms are the same.

And we have similar routines in all documents where there are currency filters as well as customer filter.

So we put it on hold for a while.

This is not a big deal. FA has operated this way since the very beginning.

Joe

Re: Print Invoice Bug

2017-12-15T17:01:31Z

There is no major change to this file. Just a currency filter in the where statement and an extra table join for it and that too only when the currency is chosen.

Re: Print Invoice Bug

2017-12-15T16:44:43Z

No, if we change this file, we will have to change most of the documents and some underlying db routines regarding currency and customer choices.

We will put this on hold to a later time.

Joe

Re: Print Invoice Bug

2017-12-15T16:33:03Z

Even if just 1 invoice is chosen and no currency filter is in place - all currencies will be allowed - there is no change in the code / sql for this choice of no currency.

@joe: should the file be committed?

Re: Print Invoice Bug

2017-12-15T14:41:19Z

no Joe, i don't think you should rewrite all the documents.. the systems just works and what i wanted was something different from the included file by apmuthu.
Just ignore this issue for now, maybe we could find a better way to print the customer's invoice in a different currency other than the default one.

Kind Regards.

Re: Print Invoice Bug

2017-12-15T14:16:54Z

Well, if you feel this is a bug, then we will have to rewrite almost all the documents. I don't understand why, because you use no resources if you do not print the white page. We have had this behaviour from the very beginning of FA.

BTW. the Customer filter also gives a blank page if the customer is not there.

Please tell me if we should rewrite.

/Joe

Re: Print Invoice Bug

2017-12-15T12:50:09Z

@apmuthu
it seems to be working, the only problem i see here is if someone wants to print only one invoice. the default currency w'll be used no matter what currency has been selected.

but i think its much better than getting a white pdf file. so maybe committing this is a good idea.