FrontAccounting forum — Adapting to google's error when getting exchange rates.

Re: Adapting to google's error when getting exchange rates.

null@example.com (joe) — Sun, 26 Nov 2017 23:14:18 +0000

Committed to stable Repo.

/Joe

Re: Adapting to google's error when getting exchange rates.

null@example.com (joe) — Sun, 26 Nov 2017 17:33:35 +0000

Willdo later.

Joe

Re: Adapting to google's error when getting exchange rates.

null@example.com (apmuthu) — Sun, 26 Nov 2017 16:21:02 +0000

@joe: want to commit this with a check for if (empty($val)) { ?

Re: Adapting to google's error when getting exchange rates.

null@example.com (apmuthu) — Sun, 26 Nov 2017 12:45:10 +0000

The reason is that it is a very big numner for these conversions:
1 EUR = 24810.7356 STD
The inverse obtained is obviously too small:
1 STD = 0.000040305133073120169802623667474011 EUR
This is more than the 4 digits after the decimal place.
Hence Google needs to increase the number of decimal places for such evaluations.
Doing it in FA with the default values will be of no use and hence @notrinos solution is elegant.

If you search for "1 STD = ? EUR" you will get 0.000040 as the answer now.
Hence their evaluator for the search engine is okay.

Incidentally, we may have a Chart of Accounts for Sao Tome among the forum users - @odaio!

~~Alternatively, if all the reverse rates work, then we can swap the currencies and make just 1 single check.~~ The reverse for IDR to OMR does not work.

USD to any currency works - hence only when a non USD is involved as the From and To currencies, we will need 2 conversions and then a division! Here we will have the second check only when the first fails.

Adapting to google's error when getting exchange rates.

null@example.com (notrinos) — Sun, 26 Nov 2017 12:30:31 +0000

I have found google does not convert following currencies STD, ITL, IRR, FRF, DEM, VND, BYR to USD but it does opposite (USD to those currencies).

Should we change lines 213-225 of gl_db_rates.inc

elseif ($provider == 'GOOGLE')
    {
        $val = '';
        
        $regexp = "%([\d|.]+)\s+{$curr_a}\s+=\s+([\d|.]+)\s+{$curr_b}\s*%s";
        if (preg_match($regexp, $contents, $matches)) 
        {
            $val = $matches[3];
            $val = str_replace(',', '', $val);
            if ($val != 0)
                $val = 1 / $val;
        }
    }

    elseif ($provider == 'GOOGLE')
    {
        $val = '';
        
        $regexp = "%([\d|.]+)\s+{$curr_a}\s+=\s+([\d|.]+)\s+{$curr_b}\s*%s";
        if (preg_match($regexp, $contents, $matches)) 
        {
            $val = $matches[3];
            $val = str_replace(',', '', $val);
            if ($val != 0)
                $val = 1 / $val;
        }
// Start of New Code lines
        if(!$val) {
                $filename = "/finance/converter?a=1&from={$curr_b}&to={$curr_a}";
                $regexp = "%([\d|.]+)\s+{$curr_b}\s+=\s+([\d|.]+)\s+{$curr_a}\s*%s";
                $contents = url_get_contents("http://".$site.$filename);
                if (preg_match($regexp, $contents, $matches))  {
                    $val = $matches[3];
                    $val = str_replace(',', '', $val);
                }
        }
// End of New code lines
    }

to adapting to the google's issue ?

if this issue will not be solved FA will shows folowing red error comment:
number_format() expects parameter 2 to be integer, float given in file: C:\xampp\htdocs\fa243\includes\current_user.inc at line 318