FrontAccounting forum — Remove double return in hooks.inc

Re: Remove double return in hooks.inc

null@example.com (itronics) — Fri, 27 Oct 2017 07:03:24 +0000

Yes, indeed in default_get_dispatchable_quantity() the last line was sparse. Fixed in repo.
While this hook is not used in main code, it can be used by extensions.
Janusz

Re: Remove double return in hooks.inc

null@example.com (joe) — Thu, 26 Oct 2017 22:55:06 +0000

Excuse me, but I see no problems here.

The last function either return the $result (if not null) or return the outcome from the static function default_get_dispatchable_quantity().
This function maybe called from a derived class of Hook.

I will, however, ask Janusz for a comment on this.

/Joe

Re: Remove double return in hooks.inc

null@example.com (apmuthu) — Thu, 26 Oct 2017 21:00:52 +0000

@joe: fix redundant returns.

Remove double return in hooks.inc

null@example.com (apmuthu) — Sat, 21 Oct 2017 10:07:02 +0000

The file includes/hooks.inc has it's last class method default_get_dispatchable_quantity() called only in the page's last function hook_get_dispatchable_quantity().

1. Is this set of functions necessary here?
2. The said method has two consecutive return statements - remove or comment one of them if they should be there for some alternative workaround for a different set of PHP versions.