FrontAccounting forum — Recurring Invoices ... A Problem

Re: Recurring Invoices ... A Problem

null@example.com (boxygen) — Sun, 05 Nov 2017 20:24:18 +0000

I have other modules too. I will check in isolation then revert to you.

Re: Recurring Invoices ... A Problem

null@example.com (cambell) — Sun, 05 Nov 2017 14:59:49 +0000

@boxygen. I don't have that problem myself. However, I can see that rep107.php does have the ability to send multiple emails if the from invoice number and to invoice number are not equal. The recurring module sets these equal so it should only ever send one email for each invoice generated. Do you have any other modules loaded?

Re: Recurring Invoices ... A Problem

null@example.com (cambell) — Sat, 28 Oct 2017 06:48:33 +0000

@boxygen. Yes, I'm using the recurring module in production. I'll have a look. I'm pretty sure that's not happened to me.

Re: Recurring Invoices ... A Problem

null@example.com (apmuthu) — Thu, 26 Oct 2017 11:28:22 +0000

The Mail Send seems to be placed in the wrong inner loop.....

Re: Recurring Invoices ... A Problem

null@example.com (boxygen) — Wed, 25 Oct 2017 08:18:29 +0000

@cambell are you using this module currently? Because I have faced a very strange behaviour from this module. I entered almost 10 recurring invoices of 10 different customers. ON due date I selected the Check All Check Box and Clicked the Generate Invoice BUtton to send invoices to all.

Invoices were created but each customer has received invoice ten times in email. It has simply multiplied the number of times each email with number of recurring invoices.

Re: Recurring Invoices ... A Problem

null@example.com (boxygen) — Tue, 17 Oct 2017 18:35:58 +0000

@cambell I shall mention that with the help of your extension I have learned one great thing. I have learned how to manage the whole menu structure of the FA from any single module.

Thanks a lot

Re: Recurring Invoices ... A Problem

null@example.com (boxygen) — Thu, 12 Oct 2017 13:09:51 +0000

@cambell may be you are right but since I have already spent a lot of time to understand FA style of coding, I felt your code a little complex. And yes you are right I am among those students who found OOP difficult to grasp.

I hope my incongruous feedback won't stop you from sharing things to FA۔

Re: Recurring Invoices ... A Problem

null@example.com (cambell) — Thu, 12 Oct 2017 07:57:09 +0000

@boxygen that's kinda funny. Most of the recurring module is a copy and paste of FA core. I hear what you're saying, I remember teaching Object Oriented Programming to beginners at a community college in the '90's. The students found object oriented concepts difficult to grasp.

The recurring module is a little complex - but, I think less complex than the existing FA implementation of a similar feature.

Re: Recurring Invoices ... A Problem

null@example.com (boxygen) — Wed, 11 Oct 2017 15:57:03 +0000

I agree with @apmuthu. I am not very good at php but since the FA code is very simple I could have managed to do some customizations for my need. Unlike I tried to read to code of Recurring Module shared by @cambell but it is too difficult for me to understand unless I am a good user of composer type things. Anyway both of you are very important resource for us

Re: Recurring Invoices ... A Problem

null@example.com (apmuthu) — Wed, 11 Oct 2017 14:27:27 +0000

FA is built for "non" computer programming professional users accustomed to the very permissive and then loosely typed PHP versions from PHP 4.x onwards to 5.3.x. Many have been long time users of FA and stability and easy understand-ability are more important than esoteric latest is greatest paradigms. I subscribe to the old fashioned procedural style where individual files are not combined by "less" and "autoloaded" by the likes of composer. To each his own.... When Sun took PHP/MySQL over they tried to make it a clone of Java/JSP. When Oracle took that over from them, they tried to make it really complex by changing even the simple array construct to practically break everything hitherto.

Re: Recurring Invoices ... A Problem

null@example.com (cambell) — Wed, 11 Oct 2017 02:26:05 +0000

@apmuthu Increasingly in modern web development there is a difference between what you code and what your ship / deploy. e.g. If using bootstrap you might code using scss fragments that are built (webpack, gulp etc) into a single css file that is shipped. Similarly for javascript, and also for any php dependencies.

I've been using composer, npm, webpack, bower (when that was something) for many years now. There are always issues with anything, but I've found the benefits to be well worth it.

The object oriented paradigm and auto load have long been core features in php for more than 10 years now. It would be nice to see FA move with the times :-)

Re: Recurring Invoices ... A Problem

null@example.com (kvvaradha) — Sun, 08 Oct 2017 16:36:19 +0000

@cambell, that's great to hear.

Re: Recurring Invoices ... A Problem

null@example.com (boxygen) — Sun, 08 Oct 2017 06:58:26 +0000

I need more help over FA Cron Processing so that Auto Create shall work for this module at least.
Thanks in advance.

Re: Recurring Invoices ... A Problem

null@example.com (apmuthu) — Sat, 07 Oct 2017 04:54:45 +0000

Making it an absolute config constant value would avoid having to set and overwrite is everywhere in erroneous relative path method that prevails now. I do not want autoload composerisation as it come with other issues.

Re: Recurring Invoices ... A Problem

null@example.com (cambell) — Sat, 07 Oct 2017 04:45:27 +0000

@kvvaradha your method doesn't work if you are wanting to use a standard report from within a custom module. The $path_to_root should be set only once, the report never checks if its defined and overwrites it with an incorrect value. The __DIR__ is correct in both cases.

Personally, I don't think that the path to root is robust (given that it should be set only once from the point of entry), I'd love to see things switch to a more modern class auto load system, and would be happy to code that for the project. It would probably take a few weeks if it was just me.