<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom">
	<title type="html"><![CDATA[FrontAccounting forum — Old Sales Quote Reference Fix]]></title>
	<link rel="self" href="https://frontaccounting.com/punbb/extern.php?action=feed&amp;tid=6950&amp;type=atom" />
	<updated>2017-08-30T04:54:29Z</updated>
	<generator>PunBB</generator>
	<id>https://frontaccounting.com/punbb/viewtopic.php?id=6950</id>
		<entry>
			<title type="html"><![CDATA[Re: Old Sales Quote Reference Fix]]></title>
			<link rel="alternate" href="https://frontaccounting.com/punbb/viewtopic.php?pid=28513#p28513" />
			<content type="html"><![CDATA[<p>Thanks apmuthu. Will fix this.</p><p>Joe</p>]]></content>
			<author>
				<name><![CDATA[joe]]></name>
				<uri>https://frontaccounting.com/punbb/profile.php?id=3</uri>
			</author>
			<updated>2017-08-30T04:54:29Z</updated>
			<id>https://frontaccounting.com/punbb/viewtopic.php?pid=28513#p28513</id>
		</entry>
		<entry>
			<title type="html"><![CDATA[Old Sales Quote Reference Fix]]></title>
			<link rel="alternate" href="https://frontaccounting.com/punbb/viewtopic.php?pid=28512#p28512" />
			<content type="html"><![CDATA[<p>When viewing an old / existing quote, the Reference Number must be taken from the table record and not the next one.</p><p>1. In file <strong>sales/view/view_sales_order.php</strong> line 42:<br /></p><div class="codebox"><pre><code>$_SESSION[&#039;View&#039;] = new Cart($_GET[&#039;trans_type&#039;], $_GET[&#039;trans_no&#039;], true);</code></pre></div><p>should be replaced with<br /></p><div class="codebox"><pre><code>$_SESSION[&#039;View&#039;] = new Cart($_GET[&#039;trans_type&#039;], $_GET[&#039;trans_no&#039;]);</code></pre></div><p>as the last parameter in the Cart class (defined in <strong>sales/includes/class_cart.inc</strong>) constructor is for determining if a new Reference is to be taken or an existing one is to be used. This is how it is <a href="https://github.com/apmuthu/frontaccounting/blob/master/core/sales/view/view_sales_order.php#L42">in FA 2.3.26</a> where the last parameter if false is omitted as that is the default for the constructor..</p><p>2. The leading semicolon (;) on line 96 can be removed as well in the same file.</p><p>3. The line 24 in the Cart class file <strong>sales/includes/class_cart.inc</strong>:<br /></p><div class="codebox"><pre><code>class cart</code></pre></div><p>can be corrected to<br /></p><div class="codebox"><pre><code>class Cart</code></pre></div><p>as it is used that way in all the scripts and in the extensions.</p><p><s>@joe: can commit this.</s> - <a href="https://github.com/FrontAccountingERP/FA/commit/4fb55e726607d40a22272c0c432c3df8b422b447">Committed</a></p>]]></content>
			<author>
				<name><![CDATA[apmuthu]]></name>
				<uri>https://frontaccounting.com/punbb/profile.php?id=364</uri>
			</author>
			<updated>2017-08-29T17:32:55Z</updated>
			<id>https://frontaccounting.com/punbb/viewtopic.php?pid=28512#p28512</id>
		</entry>
</feed>
