I should edit FA core code because there are built in functions like payment_person_name() which required modification of my types.
But now I have faced with new issue my code is in module and types.inc or gl_trans view files are not call it within FA :S

So will modify FA and keep logs, no other way to go

There are some usefull functions within FA like submenu_option, submenu_view, submenu_print where as they are but only for internal predefined types.

Anyway I have decided to copy existing similar type related functions into module and modify them with new types/names.

Would be better to have more generalized framework which will help to develop functions more easy and faster.

In FA 2.4RC1, the following new defines have been added:

//
//    Depreciation period types
//
define('FA_MONTHLY', 0);
define('FA_YEARLY', 1);
...
//    Manufacturing types
//

define('WO_MATERIALS', 2);
...
// Tax calculation algorithms used in als and purchase (depends on supplier's invoicing software)

define('TCA_TOTALS', 1); // taxes are calculated from respective net totals for all lines
define('TCA_LINES', 2); // taxes calculated for every line, then summed
//
//    Bank account owner types
//
define('BO_UNKNOWN', 0);
define('BO_COMPANY', 1);
define('BO_CUSTBRANCH', 2);
define('BO_SUPPLIER', 3);
...
// tax register type
define('TR_OUTPUT', 0); // sales
define('TR_INPUT', 1);    // purchase
...

Quite a few settings in the config.php have been migrated to the sys_prefs table on a per company basis.

You can possibly check the (ST_CUSTPAYMENT && ST_CUSTCREDIT)  in your constructs without touching the include/types.inc file.

I need to add transaction type something like ST_CREDITPAYMENT and define custom actions like delete_comments, void_bank_trans, void_gl_trans. I will add this into types.inc There are some more functions relates to this like systype_db and without hook.

But what is the reason to create these transaction types? I want to understand the purpose for this. And also why do these types are not database managed but in file.

Regards.