Please update the extensions for FA 2.4.1.

/Joe

There should be no occurrencies of the old $use_date_picker in the core, besides the one in config.php.

/Joe

Actually, the said function text_input is just defined in the extension with extra parameters and different order as well since a new parameter is at the beginning. It is not used anywhere in the extension. It is also not used in the dashboard_theme as well. We may consider removing this function in the extension. If this function gets used anywhere then the parameters and their order will affect such usage.

All instances in the core use the following construct:

$js = "";
if (user_use_date_picker())
    $js = get_js_date_picker();

@joe?

The original function in the core is used in the standard functions text_cells() and editor_view().

Committed in my FA24Extensions Repo.

I wrapped up lines 507-515 from ui_input.inc as you suggested, which resulted in a shift of the error code from line 507 to 508. Then I unwrapped these code lines again and wrapped up lines 28-47 in dashboard_ui.inc.

if (!function_exists('text_input')) {
function text_input($label, $name, $value=null, $size="", $max="", $title=false,
    $labparams="", $post_label="", $inparams="")
{
    global $Ajax;

    default_focus($name);
    if ($label != null)
        label_cell($label, $labparams);

    if ($value === null)
        $value = get_post($name);
    echo "<input $inparams type=\"text\" name=\"$name\" size=\"$size\" maxlength=\"$max\" value=\"$value\""
        .($title ? " title='$title'" : '')
        .">";

    if ($post_label != "")
        echo " " . $post_label;

    $Ajax->addUpdate($name, $name, $value);
}
}

This resulted in an errorless Dashboard setup screen and a non functioning Reminder setup screen with error code "Undefined variable: use_date_picker in file: /X/X/X/X/public_html/fa/modules/dashboard/reminder_setup.php at line 20". So function text_input() seems to be executed in dashboard_ui.inc later... Do you agree, can I leave it this way?

After I exchanged line 20 of reminder_setup.php

if ($use_date_picker)
$js .= get_js_date_picker();

with

if (user_use_date_picker ()){
    $js .= get_js_date_picker();
 }

everthing seems to work fine. Is this the way to go or should the variable "$use_date_picker" be used somehow. Please advice on both edits.

Regards,

Peter

function text_input($name, $value=null, $size='', $max='', $title='', $params='')
{
    if ($value === null)
        $value = get_post($name);

    return "<input $params type=\"text\" name=\"$name\" size=\"$size\" maxlength=\"$max\" value=\"$value\""
        .($title ? " title='$title'" : '')
        .">";
}

should be wrapped like:

if (!function_exists('text_input')) {
function text_input($name, $value=null, $size='', $max='', $title='', $params='')
{
    if ($value === null)
        $value = get_post($name);

    return "<input $params type=\"text\" name=\"$name\" size=\"$size\" maxlength=\"$max\" value=\"$value\""
        .($title ? " title='$title'" : '')
        .">";
}
}

Thank you for your help! Yet something must be terribly wrong here. I meticulously followed your instructions and I still get these "Cannot redeclare text_input()"/ blank screen errors, even in an completely new instance, freshly installed from your Git Master link, and looked up in a cacheless browser...

Any further suggestions?

Regards,

Peter

Dashboard is included in the FA 2.4.1. You may at best need the extension and make sure that the includes/dashboard.inc does not get overwritten or superseded. You can try to remove the old dashboard theme and extension first before upgrading and then install them afresh aferwards.

Do not forget to activate the dashboard for your specific company when logged in on the default company. When in the target company, make sure to enable ti for the access roles and permissions, logout, clear cache, close all browser instances and login again.

I also have the error "Cannot redeclare text_input()..."/ white screen (FA 2.4.1 with a prolonging update history) in Dashboard and Reminder Setup. As described here, I uninstalled, re-installed, deactivated, activated,disabled, enabled, choose default and dashboard themes, logged in and out, without result. Please advise.

Regards,

Peter

Dashboard extension v2.4.0.1 and dashboard_theme v2.4.0.1 are available to be installed via the official FA 2.4 extensions repo. Dashboard hooks are already present in FA 2.4 and as the said function above gets re-declared when using these plugins, they must be fixed.

Alternatively, using disposable functions / a check and unload if present can be attempted before re-defining the said function or naming it differently and using this new name in all dashboard functions (will need to be cascaded into all the dashboard type themes). Lets avoid namespaces.....and PECL runkit / APD's rename_function....

@joe: your thoughts?