FrontAccounting forum — Print a large number of invoices at once

Re: Print a large number of invoices at once

2015-02-14T03:36:36Z

This means that this error pre-existed in FA. In FA v2.4, we must make sure that $customer has some value (even if blank) before arriving at rep107.php since the very same construct "if (!exists_customer_trans(....." precedes the current commit lines of rep107.php in rep110.php and rep113.php and the equivalent "if($myrow['debtor_no'] != $customer) {" instead of the current commit lines will always be sufficient even if not coded so.

@joe: thanks for spotting and correcting it forthwith. I had tested in Windoze that was probably more forgiving of absent variables!

Re: Print a large number of invoices at once

2015-02-13T21:55:44Z

A new update of the file rep107.php has been done. please make a reload of the file from HG repository.

/Joe

Re: Print a large number of invoices at once

2015-02-13T16:34:51Z

Have you tried to clear all the cache and close all instances of your browser before trying it?

Take a dump of all variables available while entering rep107.php from each menu link instance and report the difference. It may have something to do with the $currency variable not being defined or defined wrongly - under what set of values I cannot ascertain as it works correctly for me.

Re: Print a large number of invoices at once

2015-02-13T16:24:58Z

Strange thing happened.

With the new rep107.php file, the function under 'Customer and Sales Reports' --> 'Print Invoices' works well.
However, if I go to 'Sales' --> 'Customer Transaction Inquiry' and then print individual invoice there, I get blank page.

I replaced with the old rep107.php file and then printing in 'Customer Transaction Inquiry' returns normal.

With the new rep113.php file, printing credit note in 'Customer Transaction Inquiry' has no issue.

Re: Print a large number of invoices at once

2015-02-13T16:08:17Z

Thanks both for your help! I have replaced rep107, 108, 109, 111, 112, 113 in my system and now the currency filter works perfectly! Very helpful. Thank you.

Re: Print a large number of invoices at once

2015-02-13T15:03:47Z

All reports affected by the currency filter commit other than rep108.php get their results from other functions. In FA 2.4, we can consider filtering them in the WHERE clause in the source function's SQL tself.

In rep108.php, the sql is executed inline and can hence be filtered in the WHERE clause itself instead of in the php loop after the fact. The patch below achieves it:

--- reporting/rep108.php    Fri Feb 13 20:23:10 2015
+++ reporting/rep108.php    Fri Feb 13 20:19:18 2015
@@ -86,18 +86,17 @@
    if ($orientation == 'L')
         recalculate_cols($cols);
  
-    $sql = "SELECT debtor_no, name AS DebtorName, address, tax_id, curr_code, curdate() AS tran_date FROM ".TB_PREF."debtors_master";
+    $sql = "SELECT debtor_no, name AS DebtorName, address, tax_id, curr_code, curdate() AS tran_date FROM ".TB_PREF."debtors_master WHERE 1 ";
     if ($customer != ALL_TEXT)
-        $sql .= " WHERE debtor_no = ".db_escape($customer);
-    else
+        $sql .= " AND debtor_no = ".db_escape($customer);
+    if ($currency != ALL_TEXT)
+        $sql .= " AND curr_code = ".db_escape($currency);
+
         $sql .= " ORDER by name";
     $result = db_query($sql, "The customers could not be retrieved");
 
     while ($myrow=db_fetch($result))
     {
-        if ($currency != ALL_TEXT && $myrow['curr_code'] != $currency) {
-            continue;
-        }    
         $date = date('Y-m-d');
 
         $myrow['order_'] = "";

Re: Print a large number of invoices at once

2015-02-13T05:54:43Z

@joe: Thanks. That was fast and elegant.

For the record:
ALL_TEXT, the blank string constant, is defined in include/types.inc and is included in includes/main.inc which in turn is included in includes/session.inc which is included in all report files.
Hence it may be safely used in all reports.

Re: Print a large number of invoices at once

2015-02-12T20:58:45Z

The currency filter didn't work for most documents, so these have been fixed and the 2.3 HG repo has been updated.

The fixed Invoice Document kan be downloaded here.

/Joe

Re: Print a large number of invoices at once

2015-02-12T16:44:30Z

The currency filter do not work in rep107.php. This will be fixed for 2.3 later this evening.

The Sales Group filter will require more work elsewhere, so this will have to wait and be included during 2.4.

Joe

Re: Print a large number of invoices at once

2015-02-12T16:36:59Z

@joe: Whilst incorporating the Currency filter in the appropriate report request forms, plesse try to include Sales Group filter as well. The latter will help manage exceptions easily with the help of temporary groups.

In FA 2.4, we can allow customer branches be part of multiple Sales Groups and possibly include a fallback Sales Group in the Customer record (debtor_master) as well.

Re: Print a large number of invoices at once

2015-02-12T16:16:00Z

I wil have a look into this.

Joe

Re: Print a large number of invoices at once

2015-02-12T15:41:42Z

I just looked deeper into the code in rep107 and it seems that currency is actually not considered in the filters
Those 'if' functions only cover invoices, debtor_no and email (I hope I am reading the code directly...)
Can this be fixed so to include currency filter? Many thanks.

if (!exists_customer_trans(ST_SALESINVOICE, $i))
continue;
........
if($customer && $myrow['debtor_no'] != $customer) {
continue;
}
.......

if ($email == 1)

Re: Print a large number of invoices at once

2015-02-12T15:23:40Z

apmuthu wrote:

Hope you have set the Customer Currency correctly. Otherwise, company's currency will be used and it will not be filterable. Currency is used in the payment link generation in pdf_report.inc in it's End() method. I have not been able to ascertain where else the "currency variable taken from the report request form" is used in report generation.

I think I set up the Customer Currency correctly because there is nowhere else I can set currency. I found this code in rep107

$cur = get_company_Pref('curr_default');

It seems the currency filter is not taking the Customer Currency but just the 'Home Currency' under Company Set Up.

What should I do so that the Currency Filter will work as per the Customer Currency?

Thank you.

Re: Print a large number of invoices at once

2015-02-11T18:13:43Z

@joe: The following info will be useful in getting Sales Groups into all pertinent reports:

functions in includes/ui/ui_lists.inc:

sales_groups_list($name, $selected_id=null, $special_option=false)
used in function sales_groups_list_cells
sales_groups_list_cells($label, $name, $selected_id=null, $special_option=false)
used in sales_groups_list_row
sales_groups_list_row($label, $name, $selected_id=null, $special_option=false)
used in sales/manage/customer_branches.php (data entry and updation)
used in sales/manage/recurrent_invoices.php (selection for recurrent invoice generation)

functions in sales/includes/db/sales_groups_db.inc:

The following 5 functions are used only once in sales/manage/sales_groups.php
add_sales_group($description)
update_sales_group($selected_id, $description)
delete_sales_group($selected_id)
get_sales_groups($show_inactive)
get_sales_group($selected_id)

get_sales_group_name($group_no)
used in sales/manage/recurrent_invoices.php
used in sales/create_recurrent_invoices.php

Re: Print a large number of invoices at once

2015-02-11T18:11:36Z

Hope you have set the Customer Currency correctly. Otherwise, company's currency will be used and it will not be filterable. Currency is used in the payment link generation in pdf_report.inc in it's End() method. I have not been able to ascertain where else the "currency variable taken from the report request form" is used in report generation.