FrontAccounting forum — 0-VAT again

Re: 0-VAT again

2015-03-13T23:52:32Z

Sorry guys, I've been quite busy recently (I'm still) and don't come often on this forum.
Can someone summarize the situation ? I only use 0-VAT for journal entry and payment/deposit
so some bugs in sales or supplier invoices are possible.

/Elax

Re: 0-VAT again

2015-03-13T14:27:47Z

I have attached the output of your SQL statement for the en_US-demo CoA - I do not see any duplications. Please show which ones you consider duplicate for what set of restricted unique keys.

Re: 0-VAT again

2015-03-13T11:25:43Z

As a temporary fix to enable me to correctly use FA for tax reporting I have modified the code to post net amount from SI entry now - This is implemented using QE so that the 0VAT is associated to a particular entry. For the 0VAT reporting to work the zero-rated QE must be used. The posting to the tables works correctly.

The tax report rep709 however reports each SI twice. This is as a result of the following sql query:

SELECT tt.name as taxname, taxrec.*, taxrec.amount*ex_rate AS amount,
taxrec.net_amount*ex_rate AS net_amount,
IF(taxrec.trans_type= 1 OR taxrec.trans_type=2,
IF(gl.person_type_id<>0, gl.memo_, gl.person_id),
IF(ISNULL(supp.supp_name), debt.name, supp.supp_name)) as name,
branch.br_name
FROM 0_trans_tax_details taxrec
LEFT JOIN 0_tax_types tt
ON taxrec.tax_type_id=tt.id
LEFT JOIN 0_gl_trans gl
ON taxrec.trans_type=gl.type AND taxrec.trans_no=gl.type_no AND
(tt.purchasing_gl_code=gl.account OR tt.sales_gl_code=gl.account)
LEFT JOIN 0_supp_trans strans
ON taxrec.trans_no=strans.trans_no AND taxrec.trans_type=strans.type
LEFT JOIN 0_suppliers as supp ON strans.supplier_id=supp.supplier_id
LEFT JOIN 0_debtor_trans dtrans
ON taxrec.trans_no=dtrans.trans_no AND taxrec.trans_type=dtrans.type
LEFT JOIN 0_debtors_master as debt ON dtrans.debtor_no=debt.debtor_no
LEFT JOIN 0_cust_branch as branch ON dtrans.branch_code=branch.branch_code
WHERE (taxrec.amount <> 0 OR taxrec.net_amount <> 0)
AND taxrec.trans_type <> 13
ORDER BY taxrec.trans_type, taxrec.tran_date, taxrec.trans_no, taxrec.ex_rate

I haven't looked further into this report yet, the joins are obviously pulling the data out twice when only required once.
To save time, wondered if anyone had encountered this issue before. Before I start modifying the statement.

On a longer term, when I have more time, I would like to modify the SI code to deal with input more on the lines of elax's Banking/GL entry. Unless, of course, this is dealt with in a future version of FA.

Thanks

Re: 0-VAT again

2015-03-11T12:24:59Z

@dls: I think @elax did mention some limitations, possibly for Supplier Invoices.

@elax: please have a look.

Re: 0-VAT again

2015-03-11T10:17:10Z

@apmuthu: feedback for post 39.

Same results found -ie those noted in post 40

Many thanks for help so far

Re: 0-VAT again

2015-03-11T09:42:48Z

@apmuthu: I will check the files again when I get some time later, although I didn't think i'd missed anything.

It would appear that:

trans_type 20 (SI) doesn't post net_amount (just sets it to 0) to trans_tax_details when posting SI with no items included just gl item entries.

trans_type 20 (SI) posts net_amount to trans_tax_details when posting SI with items included just gl item entries and also posts another entry to the trans_tax_details with net_amount =0

As noted Banking and Journal entry seems fine.

@elax: do you have any pointers as to where to look to sort this?

Re: 0-VAT again

2015-03-11T09:37:39Z

After comparing elax FA v2.3.19 Tax Support Patch, incorporated changes in FA 2.3.22+ as on date retaining all white space in the latter.

Please provide feedback.

Re: 0-VAT again

2015-03-11T08:19:18Z

@dls: Please note that there are real changes only in these 3 FA 2.3.22+ changed files:
config.default.php
includes/ui/items_cart.inc
gl/includes/gl_bank.php
when compared to elax patch files for 2.3.19.

Re: 0-VAT again

2015-03-11T06:53:32Z

I have removed the above

Link for gl_tax_support files for ver: 2.3.22 (0-VAT reporting)
http://91.84.138.17/FAdev/FrontaccountingTaxPatch2.3.22.rar

temporarily as this seems to have caused a problem with the reporting on the SI which was not there previously. Banking and Journal entries seem to work and report 0VAT ok.

@elax: SI doesn't post tax when just GL Items entered. When items are added into SI with GL items tax including 0VAT is posted (which was before patch) but is now reported twice?

Re: 0-VAT again

2015-03-10T17:23:31Z

Apologies, done in hast! The archive should now be correct.

Re: 0-VAT again

2015-03-10T14:10:23Z

Your archive contains a file
gl_db_bank_trans.inc
but not the file
gl/includes/db/gl_db_trans.inc.

Re: 0-VAT again

2015-03-10T11:07:10Z

Link for gl_tax_support files for ver: 2.3.22 (0-VAT reporting)

http://91.84.138.17/FAdev/FrontaccountingTaxPatch2.3.22.rar

containing:
config.default.php
gl/gl_bank.php
gl/gl_journal.php
gl/includes/db/gl_db_banking.inc
gl/includes/db/gl_db_trans.inc
gl/includes/ui/gl_bank_ui.inc
gl/includes/ui/gl_journal_ui.inc
includes/ui/items_cart.inc
js/inserts.js

Re: 0-VAT again

2015-03-10T06:44:02Z

Upload it anywhere and paste the url here.

Re: 0-VAT again

2015-03-10T06:42:25Z

Not on here sure how to post files on here. Anyone interested I'll send the zipped file to.

Re: 0-VAT again

2015-03-09T01:44:27Z

@dls: Please post the changed files that worked for FA v2.3.22+