FrontAccounting forum — Import Transactions 2.3.22-4 2.3.22-4

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (apmuthu) — Thu, 19 Mar 2015 15:28:02 +0000

Link to commit would be useful. Your commit list does not show it as yet.

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (raddison) — Mon, 16 Mar 2015 14:13:20 +0000

Code has been adjusted in the extension.

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (apmuthu) — Thu, 18 Dec 2014 16:20:50 +0000

$trial = (isset($_POST['trial']) && ($_POST['trial']!=null)) ;

is way better.

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (geoffreywalton) — Wed, 17 Dec 2014 08:45:58 +0000

I believe it sets the value to 1.

It is a very confusing way of testing if a box is checked or not.

It was failing to cater for the box not being checked.

if (isset($_POST['trial']) && ($_POST['trial']!=null)) {
$trial = true;
} else {
$trial = false;
}

Is probably neater.

HTH

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (apmuthu) — Wed, 17 Dec 2014 04:31:13 +0000

What is the meaning of $trial = !null; ? Is the value true or false? Is it's value dependent on PHP version used?

This logic can certainly do with some housekeeping.

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (geoffreywalton) — Tue, 16 Dec 2014 15:54:04 +0000

5.2.17

Re: Import Transactions 2.3.22-4 2.3.22-4

null@example.com (apmuthu) — Tue, 16 Dec 2014 09:06:23 +0000

What is the version of your PHP?

Import Transactions 2.3.22-4 2.3.22-4

null@example.com (geoffreywalton) — Mon, 15 Dec 2014 17:09:53 +0000

When testing this feature I get the message

67 Payments would have been successful if imported. Uncheck Trial check before importing.

Around line 238 of /modules/import_transactions/import_transactions.php change

// Commit import to database
if ((isset($_POST['trial'])) && ($_POST['trial']==null)){
$trial = null;
}
if (isset($_POST['trial']) && ($_POST['trial']!=null)) {
$trial = !null;
}

if (!isset($_POST['trial']) ) {
$trial = null;
}

seems to do the trick.

HTH