Last Git commit here.

Thanks, I've tried it with customer payments, and supplier payments and not a foreign exchange gain in sight.

Jonathan

Joe

Janusz

I think payment_db.inc line 49 is wrong.

$bank_amount = $amount/$rate;     should be        $bank_amount = $amount*$rate;

This does not cure the problem, because as the comment says it is not used here, but somewhere a similar mistake is causing my problem.

Another anomaly I have noticed, which probably is insignificant:
The Customer Payment  Entry form ends with the button "Update payment"
When modifying a customer payment the button reads "Add Payment"
Something has bee swapped round.

Jonathan

Take a sale of 120 euro, = £96. Payment of 120 euro = £96. (no exchange gain)

Invoice ...... 100 EUR + 20EURvat = 120 euro in all. This is shown on the invoice correctly.

G/L  4000     Sales                                                 80.00    
       1100      Debtors Control Account           96.00        
       2200      VAT (20%)                                         16.00    
                          Total                                 96.00        96.00    
This is correct, in GBP.
The G/L for Delivery is also correct , and in GBP

Customer payment  = 120 EUR      96 GBP

G/L   1200      Bank Current Account            96.00        
         1100     Debtors Control Account                          96.00    
         1100     Debtors Control Account             24.00                 Sales Invoice 5
         4920      Foreign Exchange Gain                          24.00     Sales Invoice 5
                                    Total                         120.00      120.00    

Here £120 has come out of the Debtors account, £96 to the Bank, and £24 to Exchange gain.  (120 was the Euro amount paid in)

Summary:
Invoice         £96  ... 120 euro
payment       £96  ... 120 euro
Allocation    £120 ...  150 euro

The final result is £24 Foreign exchange gain, and £24 deficit in the Debtors control account, where both should be nill.
The payment has allocated £120, not £96.

Janusz

But

It's not just the Customer Balance report, because when the payment is allocated the euro value is used instead of pounds, and the difference is recorded as Foreign Exchange gain.

Jonathan

The problem is half way to being solved.

A payment now results in the custommer's balance ( in pounds, our currency ) being credited with the euro figure, unconverted. This is not as bad as it was, ie converted in the wrong direction.

So now the sums in the foreign exchange gain are half what they were, but should be zero.

Jonathan

Problem solved, very quickly, and over the bank holiday weekend.

Many thanks
Jonathan

Janusz has fixed the problem and the repo is updated. You can download the file fix here

Joe

If the foreign customer payment is not related to in invoice the customer balance increases by an amount as if  the exchange rate is applied the wrong way round. There are no foreign exchange gains or losses.

When a direct invoice, or an order- dispatch-invoice is entered there are no foreign exchange entries.

When a payment is made, directly for an invoice, or by allocating from the customer balance (which is artificially high) then the foreign exchange entries appear. They are almost twice the difference between the euro sum and the Pound equivalent.

All the above is done with no change in rate between the actions, and no bank charges.

I wondered if the wrong value was being sent from the payment form, but the problem is still there when the allocate payment form is used.

Hope this helps

Jonathan

Thanks for the quick reply, but I installed the two files yesterday. As I said at the beginning.

So the problem remains.

Jonathan