Chris

This is great. Each item is easily manageable and easy to create new item.

Thanks to developers.

You should not get an editfield here. Just press the F4 key and you should get the items popup form.
After you have edited the sales price in the items tab and go back to the general info, you should now have a Select box. This was the subject that was fixed.

I guess we got a little offside on the subject. Maybe my fault

Mea culpa!  I probably should have created another thread for the editable-items-description-field issue, instead of mixing it in with this issue.  Anyway, I'm sorry for misunderstanding which "other thing" you were referring to!  (BLUSH!)  I just checked and, yes, the "Select" button does appear when you switch to another tab and then go back to the General Information tab.

Thanks for that!

Sounds good!  Like I said, it's a "minor" annoyance but it would be great if it could be fixed, even if only for the sake of UI consistency between screens.  Whenever someone has time/energy/interest in looking at it will be fine by me!

Thanks, again, for all the help!

Regards,

Chris

I made the changes as you stated but, unfortunately, there's no change on my system.  The item description field on the Purchasing Direct Invoice screen still does not change from a drop down list to a text-entry field if the selected item has "editable description" checked and you tab over to the "Qty" field.  I tried logging out and back in, and clearing my browser cache, but still no change.  Btw, the item description field for the same item does change in the Sales Direct Invoice screen, so there's some sort of inconsistency going on here between how the two screens are coded.

You should not get an editfield here. Just press the F4 key and you should get the items popup form.
After you have edited the sales price in the items tab and go back to the general info, you should now have a Select box. This was the subject that was fixed.

I guess we got a little offside on the subject. Maybe my fault

The other thing you mentioned will still be under consideration.

Joe

Well, it seems that I got the resources just now

Thanks, Joe, for taking the time to look into that other problem.  I'm sure you have plenty of other things to keep you busy, so I really appreciate you spending time on my issues.

I made the changes as you stated but, unfortunately, there's no change on my system.  The item description field on the Purchasing Direct Invoice screen still does not change from a drop down list to a text-entry field if the selected item has "editable description" checked and you tab over to the "Qty" field.  I tried logging out and back in, and clearing my browser cache, but still no change.  Btw, the item description field for the same item does change in the Sales Direct Invoice screen, so there's some sort of inconsistency going on here between how the two screens are coded.

As you said, this is a minor issue so if you're busy with other things just put it on the "To Do" list for when you have some free time (yeah, right!).    I can live  with the annoyance of having to save an item, go back and edit it, and then save it again as I'm a small, one-man operation and I don't enter a huge amount of direct invoices.

One side comment, though, and this isn't meant as a criticism but, rather, it's just me pointing out how things work in the world...  What may seem like a "minor" issue can be a major issue to someone who has to deal with the "minor" issue over and over, day in and day out.  At first, a data entry clerk who spends all day repeatedly entering direct purchasing invoices into FA might not mind the one or two extra steps of having to save a line, edit it, and then save it again,  but after having to do that the 10,000th time (and the 100th time today!) it can become downright infuriating!  So, sometimes, it's all those "little things" that determine whether an application is "really nice" or "just plain junk."

Anyway, thanks again very much for your help!  Put this one on the "To Do" list if your busy with other things.  Heck, now that I'm a "Master PHP Programmer" (ahem! ) I might even go figure it out myself!  LOL!

Regards,

Chris

I guess you should revert it again. Later when I get the resources, I will look at you minor item above.

/Joe

I put everything back the way it was.

Thanks!

Regards,

Chris

In the files
/items/prices.php
/items/purchasing_data.php
/items/cost_update.php
/items/reorder_level.php

look up this:

if (@$_GET['popup'])
    hidden('_tabs_sel', get_post('_tabs_sel'));

and change to

if (@$_GET['popup'])
{
    hidden('_tabs_sel', get_post('_tabs_sel'));
    hidden('popup', @$_GET['popup']);
}

This should do it.

HG repository updated.

/Joe

/Joe

Thanks!

Regards,

Chris

I manually made the changes you outlined and, yes, it now automatically populates the fields when you select an item in the pop-up window.

WOO HOO!!!! 

There's still a small problem that if I create a new item and then go to another tab (e.g. to Purchase Pricing to enter a purchase price), when I go back to the General Information tab the "Select" button is no longer at the bottom of the screen.  So, I have to refresh the screen, reselect the item to get the "Select" button back, and then click the "Select" button.

This is NOT a big deal and I'm REALLY happy just being able to use the pop-up window to create new items.  I just mention this last little thing in case there's an easy fix for it.  If not, don't worry about it.

Again, thank you VERY much for all your help!

Regards,

Chris

It turns out to be a little glitch when changing the Item list box fill a year ago. A parameter was missing in the new one.

The function in ui_lists.inc, line 776:

function stock_items_list_cells($label, $name, $selected_id=null, $all_option=false, 
    $submit_on_change=false, $all=false, $editkey = false)

indicates a final parameter $editkey. If this is true, a f4 key is available to call upp the items form in a popup window.

So in file /purchasing/includes/ui/po_ui.inc line 401:

        stock_items_list_cells(null, 'stock_id', null, false, true, false);
should have a last parameter set to true
        stock_items_list_cells(null, 'stock_id', null, false, true, false, true);

And finally there was a little bug in /inventory/manage/items.php on line 22. Should be:

page(_($help_context = "Items"), @$_REQUEST['popup'], false, "", $js);

Try to change theese lines and it will work with the f4 key. Some times you have to pres this key twice.

So F2 = customer/supplier, F3 = customer branches and F4 = items in forms where this is established.

This will be sent to the HG repository. First I will have a look into other scripts if it need changing.

You can also download the 2 files here. Rename the items.php1 to items.php and replace the files
/inventory/manage/items.php
/purchasing/includes/ui/po_ui.inc

/Joe

Did you mean:

    if ($editkey) {
        set_editor('customer', $name, $editkey);
        set_editor('item', $name, $editkey);
    }

The original code didn't have the braces so I didn't add them.  That goes to show you how much I know about PHP programming!  (BLUSH!)

Thanks for pointing that out!  I fixed it.  Now, if I could get it to automatically populate the Direct Invoice screen when I close he item pop-up screen I'd be all set!  (Hint!)

Thanks for your help!

Regards,

Chris

As mentioned in my last post, when I click the "Select" button at the bottom of the inventory/manage/items.php pop-up window, the window closes but does not update the Direct Invoice screen with the stock_id and other data for the newly-created item.  However,  I can type the new item's stock_id into the "Item Code" field, or use the drop down list, and it's there!

Also, when I create a new item in the pop-up window, if I go to another tab (e.g. "Sales Pricing") and make a change there, when I go back to the "General Settings" tab the "Select" button is no longer at the bottom of the screen.  So, I have to refresh the screen and reselect the new item to get the "Select" button back.  Then I can carry on with selecting the item and going back to the Direct Invoice screen.

So, I have accomplished what I set out to do...  I'm able to create new items from within the Direct Invoice screen.  WOO HOO!  However,  it would be nice if I could get this to work just like it does with customers and branches...  update the fields automatically, and not lose the "Select" button if I go to another tab.

Any tips/pointers on how to get it to do that?

Thanks, again, for any help provided!

Regards,

Chris