Now in order to leverage it, we need new config variables or sys_prefs entries to switch between
the default (current for backwards compatibility) Comapny Name and Company EMail and
the optional User Real name and User EMail
in determining the mail sender name and Reply-to name.
Sys_prefs would be preferable as they can be set on a per company basis. It should be coded to fall back to the other if one is absent.

The file /includes/current_user.inc can also be doenloaded here.

Please download and replace in /includes/current_user.inc.

/Joe

Since the users.email field is not being used anywhere in the code if acquired using get_user_by_login() (as is done here in line 81 of includes/current_user.inc), the following patch will ensure it's availability in any script that uses it:

--- old/includes/current_user.inc    Thu Jan 17 19:16:02 2013
+++ new/includes/current_user.inc    Mon Feb 04 05:42:49 2013
@@ -22,6 +22,7 @@
     var $loginname;
     var $username;
     var $name;
+    var $email;
     var $company; // user's company
     var $pos;
     var $access;
@@ -120,6 +121,7 @@
                 $this->username = $this->loginname;
                 $this->prefs = new user_prefs($myrow);
                 $this->user = @$myrow["id"];
+                $this->email = @$myrow["email"];
                 update_user_visitdate($this->username);
                 $this->logged = true;
                 $this->last_act = time();

            [old_db] =>
            [logged] => 1
            [ui_mode] => 1
            [prefs] => user_prefs Object
                (   edited long list
                )

            [cur_con] => 0
        )

No email.

ed10

Unless we try having both Reply-to in header and using the -f parameter with no error, we cannot include the code in the base repo as it has to ensure that existing installs with no postfix and just sendmail will still work.

When I did: echo '<pre>' . print_r($_SESSION, true) . '</pre>';
it shows no email in the wa_current_user array.       

I have not tried to use both methods.

I am using the latest verison of postfix for ubuntu from ubuntu repository so would be greatly surprised if my Postfix was non-compliant.

The RFC2822  uses CRLF and FA's class.mail.inc uses LF only.

Article 3.6.2 in the RFC2822 states:

Maybe some non compliant versions of Postfix may need the additional parameters like -f.....

Caveat - in some mail systems:

_________________________
[size=8]Composed/Posted with WYSIWYG BBCode Editor[/size]

What would really be nice would be putting all this kind of stuff into the custom report (in this case rep111 in company directory) and not the main code pages like pdf_report.inc and class.mail.inc. That would keep the custom stiff together and the main code less hacked by various FA users.  Maybe it is not even possible, but possible or not still would be nice

ed10

Take a look at:
me at arronwoods dot com
1 year ago
I've had all sorts of problems with scripts that don't set the "-f user@example.org" parameter when using mail() if postfix is the sendmail agent. ...
in http://php.net/manual/en/function.mail.php

ed10

At least that is what it looks like right now.  Time to take a break and look at it all again tomorrow to see if I have it all the way I want it.

Tomorrow is work on Mercurial day also, can't seem to get it to work right for me.

Line 82 in includes/errors.inc:

        $user = @$_SESSION["wa_current_user"]->loginname;

and Line 55 in reporting/includes/printer_class.inc:

        $ctrl = "H".$server."\nP". substr($_SESSION["wa_current_user"]->loginname,0,31) 

It is always the same as $_SESSION["wa_current_user"]->username - would the devs want to standardize?.

You can actually dump the specific session variable:

echo print_r($_SESSION["wa_current_user"], true);

at the location of the send() and see what is the output!

Line 95 in admin/db/users_db.inc in function get_users_by_login():

$sql = "SELECT * FROM ".TB_PREF."users WHERE user_id=".db_escape($user_id);

Hence all fields must be available and in your instance, the real_name field may not have been set, though in the email instance, the username may be okay.

$_SESSION["wa_current_user"] = new current_user();

Class current_user is defined in includes/current_user.inc, having class variables $loginname, $name and $username all set to empty strings in the constructor at line 42.

current_user::login() method on successful authorisation at line 81:

$myrow = get_user_by_login($loginname);

and sets the current_user class variables

                $this->name = $myrow["real_name"];
                $this->pos = $myrow["pos"];
                $this->loginname = $loginname;
                $this->username = $this->loginname;
                $this->prefs = new user_prefs($myrow);
                $this->user = @$myrow["id"];

If the session variable user is available, ordinarily from the above code, the session variable name should also be available.

When a login timeout occurs, this may not get executed fully and some session variables may get unset (needs to be checked).

Somewhere the session variablenameis getting set to an empty string after having been logged in, if it is empty.

Hence check by replacing the line 269 in reporting/includes/pdf_report.inc with any of the following:

$this->user = $_SESSION["wa_current_user"]->loginname;

// or

$this->user = $_SESSION["wa_current_user"]->username;

and see what happens!

Isn't it used when you show the users who are logged in at the bottom of the pages?