I merged what appear to be the appropriate changes (specifically, the changes in the elax/fa-textcart repository for the latest push, which was titled "Fix PO update problems"). That amounted to two changes in includes/textcart_manager.inc. I worked from the change log in fa-textcart, so that I only took changes that you made in that push. I think that I did not take any changes that are specific to your fork.

Those changes work for me, though my testing was pretty light; I did an insert, then made some changes and did an update, and it looked good.

Here is a link to a .zip file that contains my updates for 2.4.6 and this fix: https://rlhamilton.net/textcart/textcart-2.4.6.zip

Be aware that my experience with programming php and frontaccounting is pretty slim, so although this does work fine for the ways that I use textcart, it would be good if some more experienced people looked at this, too.

Thanks to elax and apmuthu for your help. I hope this update can be useful to others in the FA community.

   https://github.com/elax/fa-textcart

The latest version fixes the Purchase order update problemes. However, this version of textcart is meant to work with my fork of FrontAccountting (which includes a few non-compatible features). An up to date version of text compatible with FA 2.3 should be easily doable by uncherry picking what is specific to my FA fork.

The main update from the version you should have is the ability to set cart parameter (like customer, date, reference) etc from the text cart.

I'm happy to answer any question.

/Elax

Thanks for the response. At first, the problem was that when I went to a function such as Sales/Direct Invoice, I would get a blank page. I didn't look any further, since I didn't want to waste time if there was a 2.4 version available.

Once I knew there wasn't a formal 2.4+ version, I looked a little closer, tracking things through the error.log file.

There were four easy changes:

1) The contents of includes/manufacturing.inc were moved into inventory.inc in 2.4, so I changed the include call in textcart_manager.inc.

2) There is a call to check_edit_conflicts() in textcart/sales/sales_order_entry.php that had no arguments. That raised a fatal error, which didn't occur in 2.3.6, but I suspect the reason there is that I'm using a newer version of php (7.2), which might be pickier. I changed that call to match the equivalent call in the base version of sales_order_entry.php.

3) The base function get_standard_cost doesn't exist in 2.4.6. It was replaced by get_unit_cost, which appears to do the same thing (or close enough for my purposes). I changed calls to that function in textcart/sales/sales_order_entry.php, textcart/purchasing/po_entry_items.php, and textcart/includes/textcart_manager.inc.

4) I changed the version to 2.4.6 in textcart/_init/config so that FA would allow the extension to be enabled. (I had already done that before I sent my first message).

That got things running, with one exception.

The one problem I ran into (and which still exists), is with the update option on the text tab. In sales it works fine, but in purchasing, it doesn't. Here is how to duplicate the problem:

- Open a Purchase Order Entry or Direct Supplier Invoice
- Add a couple of items to the invoice normally
- Select the text tab, and you will see lines for the items you added:
9780982219102    + 1    $ 5.66    ^ 03/03/2019    | "Managing Writers First Edition"
9780982219119    + 1    $ 5.44    ^ 03/03/2019    | "Conversation and Community First Edition"
- Click update.
- The date moves to the item description, and the date is replaced with 0. If you select the text tab again, you will see the following:
9780982219102    + 1    $ 5.66    ^ 0    | "03/03/2019"
9780982219119    + 1    $ 5.44    ^ 0    | "03/03/2019"

I don't use update, in fact, I'm not sure what it does that can't be done with replace. Fortunately, both replace and insert appear to work fine.

I am now going another step further, merging your versions of the files under sales, purchasing, and inventory with the 2.4.6 files to see if I can come up with a version of textcart that will more closely match 2.4.6. I'm glad to share those changes with you if they work, and if you'd like to have them.

So, the bottom line is that with the changes described above, textcart works with the only exception (so far) being the update issue, which I'm able to work around.

Thanks for your help.
Richard

What do you exactly mean by it doesn't work ?
There is no version specific to work with 2.4.x planned, however I don't think there are fundamental changes between 2.3 and 2.4 which will stop it from working.
I don't use FA 2.4.x but a fork of 2.3.x and I have no plan to upgrade at the moment, therefore I am not planning to upgrade textcart to 2.4. However, I'm happy to provide guindance or help to make it work on 2.4.x

/elax

I tried the version in this forum thread, as well as the one in github, but neither works with 2.4.6, and I haven't been able to find a newer version.

Thanks for your help.

Cannot re-assign $this in /home1/dragon/public_html/dragondb/modules/textcart/includes/textcart_manager.inc on line 703

For a start, try the following in the file /modules/textcart/includes/textcart_manager.inc:
Change lines 703 and 733:

  function item_to_text($item) {

to be

  function item_to_text($item, $user_price_dec) {

After activating textcart, now i can go in Sales Order Entry but received the following error message on the top of the page.

Declaration of ItemsAdjTextCartManager::item_to_text() should be compatible with TextCartManager::item_to_text($item, $user_price_dec) in file: ..../modules/textcart/includes/textcart_manager.inc at line 711
..../modules/textcart/sales/sales_order_entry.php:30:    include_once()

Any steps I have done wrong?

Synched textcart patched file inventory/transfers.php with core
elax textcart patched files updated to latest in core (sales, inventory, purchasing)