FrontAccounting forum — PHP 8.2 commits - why change $deliver_to to $delivery_to ?

Re: PHP 8.2 commits - why change $deliver_to to $delivery_to ?

null@example.com (apmuthu) — Tue, 08 Aug 2023 18:59:56 +0000

Tnx @joe

Re: PHP 8.2 commits - why change $deliver_to to $delivery_to ?

null@example.com (joe) — Tue, 08 Aug 2023 15:00:50 +0000

This has been restored now. Fixed back to deliver_to in class. Commited to stable.

The reason this occurred was that the php 8.2 has deprecated dynamic member addings to classes, and I mistakenly took the wrong variable. Sorry for that and thanks for seeing this.

Joe

Re: PHP 8.2 commits - why change $deliver_to to $delivery_to ?

null@example.com (joe) — Tue, 08 Aug 2023 14:46:18 +0000

Thanks @apmuthu-
I will check this asap.

Joe

PHP 8.2 commits - why change $deliver_to to $delivery_to ?

null@example.com (apmuthu) — Tue, 08 Aug 2023 13:54:14 +0000

In this commit, in the file sales/includes/cart_class.inc, why was the variable $deliver_to changed to $delivery_to ?
Wonder if this is going to affect some module or other FA files.

Please note that the following files still use $cart->deliver_to, $order->deliver_to and $_SESSION['View']->deliver_to:

sales/sales_order_entry.php

sales/includes/db/sales_order_db.inc
sales/includes/ui/sales_credit_ui.inc
sales/includes/ui/sales_order_ui.inc

sales/view/view_sales_order.php