FrontAccounting forum — Supplier Description is overwritten

Re: Supplier Description is overwritten

null@example.com (Kaya89) — Fri, 28 Apr 2023 08:38:53 +0000

Once the description is set for an item in a PO, LIKE the price it should remain as it was set when cut, just if it is deliberately edited.

Re: Supplier Description is overwritten

null@example.com (joe) — Thu, 27 Apr 2023 16:02:12 +0000

These items has now been fixed and committed to stable repo.

See forum topic https://frontaccounting.com/punbb/viewt … p?id=10276

Joe

Re: Supplier Description is overwritten

null@example.com (poncho1234) — Wed, 26 Apr 2023 13:39:30 +0000

Related topic with some additional info that may be helpful:-

https://frontaccounting.com/punbb/viewtopic.php?id=8318

Joe's post #13 is particularly pertinent.

Re: Supplier Description is overwritten

null@example.com (bradlanier) — Wed, 26 Apr 2023 04:24:37 +0000

The description problem still exists. Once a PO is cut, the ENTIRE PO should remain as it was when it was cut unless it is later intentionally edited. If the price is changed later for the item for that supplier, we do not go back and change the price in the PO that was already cut. That being said, then why go back and change the description in an existing PO? Once the description is set for an item in a PO, LIKE the price it should remain as it was set when cut UNLESS it is deliberately edited.

As far as the pricing goes, I would recommend removing the rounding.

Re: Supplier Description is overwritten

null@example.com (joe) — Wed, 19 Apr 2023 14:55:07 +0000

Hello again,

@ckrosco
I understand your problem with the price decimals. We could simply remove the rounding and only calculate the $price = $price * $data['conversion_factor']. This lets you decide how many decimals the $price should be in. Or as you showed, 6 decimals. What do you think?

Joe

Re: Supplier Description is overwritten

null@example.com (joe) — Wed, 19 Apr 2023 05:21:23 +0000

@ckrosco
The supplier_code should only be updateded if there is no data for supplier price record. So this has been changed and committed.
Please replace the file on your server.

Regarding the price truncation, I will have a closer look into this.

Joe

Re: Supplier Description is overwritten

null@example.com (ckrosco) — Tue, 18 Apr 2023 18:48:46 +0000

As I mentioned above, I am not a programmer. But these changes are solving my problems:

purchasing/includes/purchasing_db.inc

line 113

if ($description = "")

line 109

$price = round($price * $data['conversion_factor'], 6);

Trouble is I have to remember to make these changes every time I upgrade.

FrontAccounting is great! These little hitches cause me grief, but at least I can mess with the code.

But if my messing is going to break something, please let me know!

Re: Supplier Description is overwritten

null@example.com (ckrosco) — Tue, 18 Apr 2023 18:21:23 +0000

ckrosco wrote:

apmuthu wrote:
@ckrosco: If you still want t, then your code should be checked:

Thanks - that's good to know. (non-programmer here)

So I just tried it with == but then the suppliers description becomes blank. If I just use one = the suppliers description remains intact.

Re: Supplier Description is overwritten

null@example.com (ckrosco) — Tue, 18 Apr 2023 17:56:56 +0000

apmuthu wrote:

@ckrosco: If you still want t, then your code should be checked:
if ($description = "")
is an assignment but it should be
if ($description == "")
which is a comparison.

Thanks - that's good to know. (non-programmer here)

Re: Supplier Description is overwritten

null@example.com (ckrosco) — Tue, 18 Apr 2023 17:48:23 +0000

And another really irritating change that happens during this order process is that the purchase price is truncated to the default number of decimal points.

I put the price in at 2.569879 but after processing the order it becomes 2.57 - which is wrong.

These names and prices were put in randomly. In my actual business I have several products that I buy in lots of 42. The per item price is e.g. 13.6904761905 X 42 = 575

When the price is truncated I get a decimal amount, and the supplier's currency does not use decimals.

Re: Supplier Description is overwritten

null@example.com (ckrosco) — Tue, 18 Apr 2023 17:38:14 +0000

I don't see a way to add two photos, so here is the second screen shot after processing the order.

Re: Supplier Description is overwritten

null@example.com (ckrosco) — Tue, 18 Apr 2023 17:36:26 +0000

The only person(s) that need to know the suppliers code is the suppler himself. Right?

Right. But the supplier code is changed to $description everytime the supply order is processed (purchase order entry -> receive purchase order items -> enter supplier invoice)

Please see the attached screen shots. I created a product called "General Settings name" with the suppliers description = "supplier's code"

After processing the order, the suppliers description becomes "General Settings name".

Re: Supplier Description is overwritten

null@example.com (apmuthu) — Tue, 18 Apr 2023 17:24:27 +0000

@ckrosco: If you still want t, then your code should be checked:

if ($description = "")

is an assignment but it should be

if ($description == "")

which is a comparison.

Re: Supplier Description is overwritten

null@example.com (joe) — Tue, 18 Apr 2023 06:46:53 +0000

Hello @ckrosco

The only place the supplier's code or Description is shown is on the written purchase order. On all other places we are using our own name due to internal confusion otherwise.

So this is not a bug. The only person(s) that need to know the suppliers code is the suppler himself. Right?

Joe

Supplier Description is overwritten

null@example.com (ckrosco) — Mon, 17 Apr 2023 20:34:27 +0000

Items and Inventory -> Items -> Purchase Pricing

On every "Purchase Order Delivery" action the "Supplier's Code or Description" is overwritten with the product name in the "General Settings" tab.

Here is the fix:

purchasing/includes/purchasing_db.inc

Line 113

    if ($description != "")
        $sql .= ",supplier_description=".db_escape($description);
    $sql .= " WHERE stock_id=".db_escape($stock_id)." AND supplier_id=".db_escape($supplier_id);

should be:

    if ($description = "")
        $sql .= ",supplier_description=".db_escape($description);
    $sql .= " WHERE stock_id=".db_escape($stock_id)." AND supplier_id=".db_escape($supplier_id);