I hope you are looking at the last committed code from the core.

In the Invoice case we are first testing for $type == ST_SALESINVOICE before the return action (not voiding).

The code works smoothly. And it falls down to post_void_customer_trans with the correct $type and $type_no.

The $type and $type_no are never changed inside the function.

Joe

Customerpayment fall through the invoice,  there we are passing only the trans_no. Not type. So what happens that tries to check the same customer payment trans_no on invoice.  If the invoice exist. It voids the invoice instead of payment.

I am sure that fall through idea is not good here. So you need to have separate post_void_customer_trans.  Hope you got me explanation. If not let me explain with an example

There are no missing breaks. I will explain.

The Customer Payment and the Sales Invoice must fall thru down to post_void_customer_trans($type, $type_no) on line 63 (inside ST_CUSTCREDIT and ST_CUSTDELIVERY.

Joe

Break is missing for  payment and invoice  cases.  Can we try this. ?

Did you download the new file /admin/db/voiding_db.inc and replaced it after the new install from sourceforge.net?
This install file is not updated yet. This file is only updated after a new release.

Joe

Still getting the same error with 2.4.14 from source forge.

Let me know if I can help narrow it down.

Dx

Dx

Joe

Line 48 should read:
if ($type == ST_SALESINVOICE && is_cust_invoice_credited($type_no))

That way, the call to is_cust_invoice_credited is not called unless the type is an invoice.

This has been fixed in the core and committed to stable repo.

The fixed file can be downloaded here.

Joe

The code is indeed broken.  A void of a customer payment shouldn't fall through the case statement and check for an invoice using the same transaction number (is_cust_invoice_credited).

This should be an easy fix.  You can condition the call to cust_invoice_credited with && $type == ST_SALES_INVOICE

Doing a diff on the two files shows they are the same.

Happy to cary out any experiments that might be useful!

Dx

This invoice cannot be voided because it was already credited.
/PATH/frontaccounting/includes/ui/ui_msgs.inc:14:    trigger_error('This invoice cannot be voided because it was already credited.','256')
/PATH/frontaccounting/admin/void_transaction.php:320:    display_error('This invoice cannot be voided because it was already credited.')
/PATH/frontaccounting/admin/void_transaction.php:345:    handle_void_transaction()