• From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Topic: Spinner on download keeps spinning

When a backup is created and an attempt is made to download the backed-up file which downloads successfully, the spinner at the top keeps spinning and there is no message to state that the download was successful.

When a backed-up file is attempted to be viewed, there is no sql file extraction on archived backups before a view is attempted. If there is no intention of doing it for some reason, then a filter should be made before an attempt to allow a view like:

        if (!preg_match("/\.sql$/", $fname))
            display_error(_("You can only view *.sql backup files"));
        else {
..
..

in admin/backups.php file.

apmuthu's Website

  • Registered: 12/25/2007
  • Posts: 2,446

Re: Spinner on download keeps spinning

Yes, indeed. I'm not sure when the bugs slipped in, but I will try to fix them asap.
Janusz

  • Registered: 12/25/2007
  • Posts: 2,446

Re: Spinner on download keeps spinning

Fixed.
Janusz

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Spinner on download keeps spinning

@itronics: That was a really involved fix indeed. The second if to test for a zip can be an elseif..... in admin/backups.php and a string somewhere to indicate that the file was successfully downloaded will complete it.

apmuthu's Website