• From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Topic: Extra arg in submit_return() usage and F4 popup fix

The function submit_return() defined in includes/ui/ui_input.inc takes in 3 arguments but it's usage in inventory/manage/items.php shows 4 arguments. The last one in it can be omitted.

Please note that it's usage in items.php when F4 is invoked (or independantly invoked as in http://localhost/fa24//inventory/manage/items.php?stock_id=101&popup=1) hides the "Select" button on item change in drop down box or on update. This needs to be rectified. This is because when first invoked, the GET parameter popup=1 is available. On subsequent ajax and other posts, it is not available and the conditional submit() in the submit_return() blanks it out.

The actual Items Select button html is:

<button 
        class="ajaxsubmit"
        type="submit" 
        aspect="selector" rel="101"
        name="select" 
         id="select" 
        value="Select" 
        title="Select this items and return to document entry.">
    <img height="12" 
         alt="" 
         src="../../themes/default/images/ok.gif">
    <span>Select</span>
</button>

apmuthu's Website

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Extra arg in submit_return() usage and F4 popup fix

The final fix for this would be to replace the following lines in inventory/manage/items.php:

        submit_center_first('addupdate', _("Update Item"), '', 
            $page_nested ? true : 'default');
        submit_return('select', get_post('stock_id'), 
            _("Select this items and return to document entry."), 'default');

with

        if (@$_REQUEST['popup']) hidden('popup', 1);
        submit_center_first('addupdate', _("Update Item"), '', 
            $page_nested ? true : 'default');
        submit_return('select', get_post('stock_id'), 
            _("Select this items and return to document entry."));

@joe: you can commit this now.
Committed

apmuthu's Website