Topic: Duplicate code in WriteOff in FA 2.3
In FA 2.3.x, lines 202-206 in sales/includes/db/sales_credit_db.inc:
add_stock_move_customer(ST_CUSTCREDIT, $credit_line->stock_id, key($credit_note->trans_no), $credit_note->Location, $credit_note->document_date, $reference, -$credit_line->qty_dispatched, $curr_std_cost, 0, $price, $credit_line->discount_percent);
are duplicately executed for $credit_type WriteOff as it is present in lines 209-213 as well.
Committed in my repo's FAMods.
@joe: can update in upstream.
In FA 2.4, there appears to be no WriteOff distinction for the $credit_type and it stands committed.