• From: Singapore
  • Registered: 03/12/2015
  • Posts: 59

Topic: Supplier Credit Note Incorrect Header and GST

Hi there,

I have found 2 issues in the Supplier Credit Note.  The URL is purchasing/supplier_credit.php?New=1

1.   The header "Qty Yet To Credit" should be "Unit Price To Credit" as the data are the unit price.  For this, I have updated  this file purchasing/includes/ui/invoice_ui.inc and that seems OK now.

2.   If I were to make credit to multiple invoices, only the GST of the first instance of invoice I selected is computed and displayed.  The GSTS of the 2nd instance of clicks on the lines/invoices onwards are not included.  --- How to rectify this?  Please advise.

I have a screen shot showing the errors at this link: http://www.mgatech-sg.com/images/ErrorOnSupplierCredit-2.3.23.jpg


Thank you.

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Supplier Credit Note Incorrect Header and GST

Your computation of GST (in the notes) assumes 70% for Item 1 instead of 7%. FA calculates it correctly.

The label for the column "Qty yet to Credit" should be "Rate".
@joe: Please change this.

Post's attachments

ErrorOnSupplierCredit-2.3.23.jpg 230.5 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.

apmuthu's Website

  • From: Singapore
  • Registered: 03/12/2015
  • Posts: 59

Re: Supplier Credit Note Incorrect Header and GST

Hi APMuthu,

I'm sorry I have made a typo mistake. It should be 0.07 x 10,000 = 700.  The tax for 2nd item is 1500 x 0.07 = 105. The tax rate for both items is 7% and the unit price are inclusive of the 7% tax.

If you take a look at the screen shot again, I actually credit both items. For both items, the total GST should be 805 and not 700.  700 is only from one of the items, item 1.

I noticed that if I click on the 2nd item first, then followed by 1st item, the GST will only show from the 2nd item which is 105.  I have tested with multiple items with tax to credit, the tax showed always only from the item I first click and not all of them items.

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: Supplier Credit Note Incorrect Header and GST

I will have a look at this. I am out of office until monday.
Then I will have a look.

/Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: Supplier Credit Note Incorrect Header and GST

This has now been resolved. GIT repository for 2.3.24 has been updated.

You can download the two files here:

/purchasing/includes/ui/invoice_ui.inc and
/purchasing/supplier_credit.php.

Please replace the files on your server.

/Joe

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Supplier Credit Note Incorrect Header and GST

@joe: Thanks. That was a nice fix.

apmuthu's Website

  • From: Singapore
  • Registered: 03/12/2015
  • Posts: 59

Re: Supplier Credit Note Incorrect Header and GST

@joe, @apmuthu:  Thank you.

/Mark

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Supplier Credit Note Incorrect Header and GST

@mark0300: Kindly post a revised screenshot after the fix. The demo data does not have a sample with data for this screen for posting in the wiki.

Post's attachments

2015-04-30_025509.png 16.7 kb, file has never been downloaded. 

You don't have the permssions to download the attachments of this post.

apmuthu's Website

  • From: Singapore
  • Registered: 03/12/2015
  • Posts: 59

Re: Supplier Credit Note Incorrect Header and GST

@APMuthu,

Sure.  I will do it next week as I'm away.

Thanks.

  • From: Singapore
  • Registered: 03/12/2015
  • Posts: 59

Re: Supplier Credit Note Incorrect Header and GST

Hi,

How can I attach the screen shot directly on this post?

/Mark

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Supplier Credit Note Incorrect Header and GST

Upload the file anywhere and paste the url here. @joe needs to give you upload rights.

apmuthu's Website

  • From: Singapore
  • Registered: 03/12/2015
  • Posts: 59

Re: Supplier Credit Note Incorrect Header and GST

@APMuthu, @Joe,

The scripts work correctly.  I managed to get it done now instead of next week.  Below are 2 screen shots, before and after the new scripts.  Thanks guys.

http://www.mgatech-sg.com/images/Purchase-CreditNote-Before.jpg
http://www.mgatech-sg.com/images/Purchase-CreditNote-After.jpg

/Mark

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: Supplier Credit Note Incorrect Header and GST

@mark0300: Thanks. Attached herewith.

Post's attachments

Before_and_after_screenshots.zip 200.1 kb, 1 downloads since 2015-05-02 

You don't have the permssions to download the attachments of this post.

apmuthu's Website