• joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: reports_classes.inc:40: count()

We only need to include the 2 changes made by @notrinos.
The inclusion of the ui_globals.inc has already been done in other places.

Committed to repo 2.4.7 stable.

/Joe

  • From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Re: reports_classes.inc:40: count()

All reporting/repXXX.php files call the reporting/includes/pdf_reports.inc based on destination chosen in the report request form.

All reporting/repXXX.php files are called only from reporting/reports_main.php which in turn "includes" the includes/ui.inc and that in turn "includes" the includes/ui/ui_globals.inc file (among others) that defines the function count_array().

Hence no need for separate inclusion of includes/ui/ui_globals.inc except when the reports are used independent of the above file.

Wonder why Line 374 was left out from such a change in reporting/includes/pdf_report.inc.

        $count = count($this->headers2);

apmuthu's Website