• From: Singapore, India, Chennai
  • Registered: 05/02/2009
  • Posts: 6,089

Topic: array_combine() object issue

array_combine() now returns array() instead of FALSE when two empty arrays are provided as parameters.

in later versions of PHP.

To ensure compatibility with later versions of PHP whilst retaining backward compatibility, most instances of array_combine(... have been replaced with (object)(array_combine(... except in includes/ui/ui_lists.inc which may be set right now in both branches.

Line 2370 in FA 2.3.25+ and line 2538 in FA 2.4RC1+:

    $services = array_combine(array_keys($payment_services), array_keys($payment_services));

should now become:

    $services = (object)array_combine(array_keys($payment_services), array_keys($payment_services));

Fixed in my FA 2.3.x repo.

apmuthu's Website

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: array_combine() object issue

There is also an instance in includes/main.inc on line 421 in 2.4.

I will fix this asap.

/Joe

  • joe
  • Administrator
  • Offline
  • Registered: 03/15/2007
  • Posts: 5,085

Re: array_combine() object issue

All fixed in repository. Both 2.3 and 2.4.

/Joe